diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2014-10-09 01:43:05 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@kdab.com> | 2014-10-14 17:51:34 +0200 |
| commit | 65dd5ce869b1c46c70e711c59b061d8e3eb84d88 (patch) | |
| tree | a3dc108778bf6e726379c685b44a196e66e507f6 /src/designer/data/generate_shared.xsl | |
| parent | a96a15e40fe3a7b9f27582ae7c370d79bd314d66 (diff) | |
uic: don't use QStringLiteral in comparisons
For QLatin1String, operator== is overloaded, even for QStringRef,
so comparing to a latin-1 (C) string literal is efficient,
since strlen() is comparatively fast.
OTOH, QStringLiteral, when not using RVO, litters the code with
QString dtor calls, which are not inline. Worse, absent lambdas,
it even allocates memory.
So, just compare using QLatin1String instead.
Change-Id: Ice92d40342cb3939e8697d3f778f4421f5f967a1
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/designer/data/generate_shared.xsl')
| -rw-r--r-- | src/designer/data/generate_shared.xsl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/designer/data/generate_shared.xsl b/src/designer/data/generate_shared.xsl index b2db55536..bc8443329 100644 --- a/src/designer/data/generate_shared.xsl +++ b/src/designer/data/generate_shared.xsl @@ -142,7 +142,7 @@ </xsl:when> <xsl:when test="$xs-type='xs:boolean'"> <xsl:value-of select="$val"/> - <xsl:text> == QStringLiteral("true")</xsl:text> + <xsl:text> == QLatin1String("true")</xsl:text> </xsl:when> <xsl:when test="$xs-type='xs:long'"> <xsl:value-of select="$val"/> |