diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-07-31 12:48:24 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-07-31 20:31:47 +0000 |
| commit | 2ea853ba28e359fba7f98ba1286bc5c89a48105a (patch) | |
| tree | 1f4118b793162529f9f725437b5fa0da60dc9394 /src/designer/src/components/formeditor/qdesigner_resource.cpp | |
| parent | 7e64a97986537fab1105385be8ce70f174ca5118 (diff) | |
Qt Designer: Fix clang-tidy warnings about Qt usage
- Use multi-arg form of QString::arg()
- Fix static method calls
- Prefer QFileInfo::exists()
- Use isEmpty() for containers instead of checking size()
- Use QOverload
Change-Id: I31e92f77d0fa377932c1369afe2503abc8ecceac
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Diffstat (limited to 'src/designer/src/components/formeditor/qdesigner_resource.cpp')
| -rw-r--r-- | src/designer/src/components/formeditor/qdesigner_resource.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/designer/src/components/formeditor/qdesigner_resource.cpp b/src/designer/src/components/formeditor/qdesigner_resource.cpp index e79f1897b..78882fdfa 100644 --- a/src/designer/src/components/formeditor/qdesigner_resource.cpp +++ b/src/designer/src/components/formeditor/qdesigner_resource.cpp @@ -779,8 +779,9 @@ QWidget *QDesignerResource::create(DomUI *ui, QWidget *parentWidget) QWidget *QDesignerResource::create(DomWidget *ui_widget, QWidget *parentWidget) { const QString className = ui_widget->attributeClass(); - if (!m_isMainWidget && className == QStringLiteral("QWidget") && ui_widget->elementLayout().size() && - !ui_widget->hasAttributeNative()) { + if (!m_isMainWidget && className == QStringLiteral("QWidget") + && !ui_widget->elementLayout().isEmpty() + && !ui_widget->hasAttributeNative()) { // ### check if elementLayout.size() == 1 QDesignerContainerExtension *container = qt_extension<QDesignerContainerExtension*>(core()->extensionManager(), parentWidget); |