clazy: Fix clazy-detaching-temporary

Fix in Qt Designer, pixeltool, qtattributionsscanner and qtpaths.

Change-Id: Ideae055e8880552c1b8bf5a2a38326ac1356ffcb
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

2 files changed, 2 insertions, 2 deletions

diff --git a/src/pixeltool/main.cpp b/src/pixeltool/main.cpp
index 36f411749..3e17d61b5 100644
--- a/src/pixeltool/main.cpp
+++ b/src/pixeltool/main.cpp
@@ -68,7 +68,7 @@ int main(int argc, char **argv)
     QPixelTool pixelTool;
 
     if (!parser.positionalArguments().isEmpty()) {
-        const QString previewImageFileName = parser.positionalArguments().first();
+        const QString previewImageFileName = parser.positionalArguments().constFirst();
         if (QFileInfo(previewImageFileName).exists()) {
             QImage previewImage(previewImageFileName);
             if (!previewImage.size().isEmpty())
diff --git a/src/pixeltool/qpixeltool.cpp b/src/pixeltool/qpixeltool.cpp
index 6e4c9f9ff..1d94ddb8a 100644
--- a/src/pixeltool/qpixeltool.cpp
+++ b/src/pixeltool/qpixeltool.cpp
@@ -562,7 +562,7 @@ void QPixelTool::saveToFile()
     }
 
     while (fileDialog.exec() == QDialog::Accepted
-        && !m_buffer.save(fileDialog.selectedFiles().first())) {
+        && !m_buffer.save(fileDialog.selectedFiles().constFirst())) {
         QMessageBox::warning(this, QLatin1String("Unable to write image"),
                              QLatin1String("Unable to write ")
                              + QDir::toNativeSeparators(fileDialog.selectedFiles().first()));