Qt Designer: Fix crash in "Go to slot" dialog when no signal is selected

Add a check for the selection.

Task-number: QTBUG-61009
Change-Id: Ic99d8ca2b9b838b2cb24f1cf4b259c38e2a6f1ca
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

1 files changed, 10 insertions, 7 deletions

diff --git a/src/designer/src/lib/shared/qdesigner_taskmenu.cpp b/src/designer/src/lib/shared/qdesigner_taskmenu.cpp
index f0d40161c..946673553 100644
--- a/src/designer/src/lib/shared/qdesigner_taskmenu.cpp
+++ b/src/designer/src/lib/shared/qdesigner_taskmenu.cpp
@@ -707,14 +707,17 @@ void QDesignerTaskMenu::navigateToSlot(QDesignerFormEditorInterface *core,
 
     dialogUi.signalList->resizeColumnToContents(0);
 
-    if (selectSignalDialog.exec() == QDialog::Accepted) {
-        QTreeWidgetItem *selectedItem = dialogUi.signalList->selectedItems().first();
-        const QString signalSignature = selectedItem->text(0);
-        const QStringList parameterNames = qvariant_cast<QStringList>(selectedItem->data(0, Qt::UserRole));
+    if (selectSignalDialog.exec() != QDialog::Accepted)
+        return;
+    const QList<QTreeWidgetItem *> &selectedItems = dialogUi.signalList->selectedItems();
+    if (selectedItems.isEmpty())
+        return;
+    const QTreeWidgetItem *selectedItem = selectedItems.constFirst();
+    const QString signalSignature = selectedItem->text(0);
+    const QStringList parameterNames = qvariant_cast<QStringList>(selectedItem->data(0, Qt::UserRole));
 
-        // TODO: Check whether signal is connected to slot
-        core->integration()->emitNavigateToSlot(objectName, signalSignature, parameterNames);
-    }
+    // TODO: Check whether signal is connected to slot
+    core->integration()->emitNavigateToSlot(objectName, signalSignature, parameterNames);
 }
 
 // Add a command that takes over the value of the current geometry as