diff options
| author | Jesus Fernandez <jesus.fernandez@qt.io> | 2018-07-31 15:37:29 +0200 |
|---|---|---|
| committer | Jesus Fernandez <Jesus.Fernandez@qt.io> | 2018-08-20 15:14:36 +0000 |
| commit | bb3e078e2ed79e763b16c8c7f872b4ebfc576cb6 (patch) | |
| tree | 45450e39f878c1d75ab5e4f80dd74d2412c67412 /src | |
| parent | bc7ed4f112c85ac9db5a4126eb446591e0283bc3 (diff) | |
Fix division by zero
CID 191124 (#1 of 1): Division or modulo by float zero (DIVIDE_BY_ZERO)
3. divide_by_zero: In expression 60. / (double)numberOfFiles, division by expression numberOfFiles which may be zero has undefined behavior.
CID 191125 (#1 of 1): Division or modulo by float zero (DIVIDE_BY_ZERO)
3. divide_by_zero: In expression 27. / (double)numberOfIndices, division by expression numberOfIndices which may be zero has undefined behavior.
Change-Id: If4f4a6795c1dfcae904ef7279ab25a1f855a6387
Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/assistant/qhelpgenerator/helpgenerator.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/assistant/qhelpgenerator/helpgenerator.cpp b/src/assistant/qhelpgenerator/helpgenerator.cpp index 74b8d0fd1..ab42bd24f 100644 --- a/src/assistant/qhelpgenerator/helpgenerator.cpp +++ b/src/assistant/qhelpgenerator/helpgenerator.cpp @@ -226,9 +226,9 @@ void HelpGeneratorPrivate::setupProgress(QHelpProjectData *helpData) // contents 10% // files 60% // indices 27% - m_contentStep = 10.0/double(helpData->customFilters().count()); - m_fileStep = 60.0/double(numberOfFiles); - m_indexStep = 27.0/double(numberOfIndices); + m_contentStep = 10.0 / qMax(helpData->customFilters().count(), 1); + m_fileStep = 60.0 / qMax(numberOfFiles, 1); + m_indexStep = 27.0 / qMax(numberOfIndices, 1); } void HelpGeneratorPrivate::addProgress(double step) |