summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* disable tools that don't make sense on iOS more sensiblyv5.12.0-alpha1Oswald Buddenhagen2018-09-111-3/+4
| | | | | | | | | | | the primary method of doing that is via the -nomake tools machanism, which is the default when cross-building. amends 78df61b51. Fixes: QTBUG-70454 Change-Id: I837d5d130c1295154dab5d0424da46dacbfe2a34 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* remove bogus gui dependency from macdeployqtOswald Buddenhagen2018-09-113-1/+2
| | | | | | | | | | | | | | ... and build it even when building with -nomake tools, like the other *deployqt tools. note that we still don't build it when cross-building for uikit, because the bootstrapped host build does not work due to a QProcess dependency. that's no loss, because all our uikit builds are currently static, where this tool is pointless. Task-number: QTBUG-58827 Change-Id: I8eda4a85716ceeb844a3e97f5f38d35868cffeef Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Merge remote-tracking branch 'origin/5.11' into 5.12Liang Qi2018-09-118-29/+70
|\ | | | | | | | | | | | | | | Conflicts: src/macdeployqt/shared/shared.h src/qdoc/sections.cpp Change-Id: I708a20d0061e82b99ecced7d24e7a2b8c475f706
| * Merge remote-tracking branch 'origin/5.11.2' into 5.11Qt Forward Merge Bot2018-09-096-13/+39
| |\ | | | | | | | | | Change-Id: I3fe629d8a2493504e8cfea56c590db4fc92e3d56
| | * QDoc: Link correctly to enums as function parametersv5.11.2Paul Wicking2018-09-031-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Include enum type in findChildNode check, to resolve page nodes correctly. The missing check causes QDoc to not link to enums when they are function parameter types. This behavior constitutes a regression from 5.10. Task-number: QTBUG-70231 Change-Id: I57f94c08b0e207567e97127d0b7e268d90d051aa Reviewed-by: Martin Smith <martin.smith@qt.io>
| | * qmake: Add test functions for comparing version numbersAlexander Volkov2018-09-031-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | qmake really lacks version comparing functions: users either use ugly constructions to compare versions by components, such as greaterThan(QT_CLANG_MAJOR_VERSION, 3)|greaterThan(QT_CLANG_MINOR_VERSION, 4): or even incorrectly compare versions as strings: !lessThan(apple_clang_ver, "5.1")|!lessThan(reg_clang_ver, "3.4"): Add test functions versionAtLeast and versionAtMost which use QVersionNumber to compare version numbers by components. Change-Id: I65e6b3c296d0301d544b7e38bf3d44f8d555c7fc Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io> (cherry picked from qtbase/8a3e8856e5606ec616d4420ff8c4f77969432390) Task-number: QTBUG-70299 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
| | * Doc: Extend description of Clang dependency for QDocPaul Wicking2018-08-301-10/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump Clang version to 6.0. * Include description of setting environment variable on Windows Task-number: QTBUG-65762 Change-Id: Ib0ee615f852580a75033eb8d188da0270def7b3e Reviewed-by: Martin Smith <martin.smith@qt.io>
| | * QDoc: Add check to avoid links to internal classes in online docsPaul Wicking2018-08-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change prohobits QDoc from generating links to internal classes, that cause thousands of 404s in the online docs. Task-number: QTBUG-67572 Change-Id: I241be67890ed139705128ea021ca084542d4b6bc Reviewed-by: Martin Smith <martin.smith@qt.io> Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
| | * qdoc: Restore the correct output directory for example imagesTopi Reinio2018-08-281-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit ef5dc9d4 introduced a regression where the images used in examples are not copied to the correct output directory. Task-number: QTBUG-70218 Change-Id: I2a1b8a48e9b956e0f6dcc3318abc8b6400eb19e0 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
| | * Qt Designer: Fix crash when reloading resourcesFriedemann Kleint2018-08-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Initialize DesignerPropertyManager::m_object in the constructor Task-number: QTCREATORBUG-18342 Change-Id: I7acc7c12855b4775544a85fd000089cdcd6277af Reviewed-by: Eike Ziller <eike.ziller@qt.io>
| * | macdeployqt: Deploy plugins when -no-framework is usedAndy Shaw2018-09-032-16/+30
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When it was detecting the plugins to deploy, it would only work when Qt was configured as frameworks. This ensures that this case is accounted for. [ChangeLog][macdeployqt] Now deploys plugins when Qt is configured with -no-framework Fixes: 5.11.3 Fixes: 5.12.0 Task-number: QTBUG-68823 Change-Id: I05997150328a93c15609abc1759846b7a184f82a Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* | qdoc: Allow parameters for \code, \qml, \js, and \badcode commandsTopi Reinio2018-09-092-7/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow optional parameters for commands that enclose code snippets. This is intended for replacing simple strings within the snippet, typically using a macro that extends to certain parameter(s). Within the snippet, the parameter locations are marked similarly to .qdocconf macro parameters: \code foo bar \1+\2=\1\2 \encode Renders "foo+bar=foobar" A code snippet parameter cannot contain spaces, as space is used as a delimiter. If no parameters are passed, the snippet is rendered as-is. Task-number: QTBUG-67818 Change-Id: I500e6b1a9095c9c55f47c8d75951792f31745545 Reviewed-by: Martin Smith <martin.smith@qt.io>
* | qdoc: Add regular expression matching to macrosTopi Reinio2018-09-092-20/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds support for a special format (.match) option to QDoc macros. The use case is to do additional regular expression pattern matching for expanded macros; For example, macro.qtminorversion = "$QT_VER" macro.qtminorversion.match = "\\d+\\.(\\d+)" creates a macro that expands to the minor version based on the QT_VER environment variable. A macro that defines a match pattern outputs all capture groups concatenated together, or the exact matched string if the pattern does not contain any capture groups (parentheses). Task-number: QTBUG-67818 Change-Id: I8dd5b08a05555b381d100e30aaef7a9930710993 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Martin Smith <martin.smith@qt.io>
* | Fix crash when expanding macros in sectionsKai Koehne2018-09-061-1/+1
| | | | | | | | | | | | | | | | | | Do not rely on endPos, but instead use the length of the macro already calculated. This amends commit 85bc558660 . Task-number: QTBUG-67818 Change-Id: Icc0268e67eceee83bb5510b5199684c465b2dd56 Reviewed-by: Martin Smith <martin.smith@qt.io>
* | qdoc: Don't list inherited members on obsolete members pageMartin Smith2018-09-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | This update fixes the part of the bug where inherited members were being listed on the obsolete members page. They are no longer listed there. Change-Id: Ibd9cc0af22deda501d5ec7eb09e472840831f256 Task-number: QTBUG-70321 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* | qdoc: Only list obsolete members in details sectionMartin Smith2018-09-061-2/+3
| | | | | | | | | | | | | | | | | | | | | | This update fixes the part of the bug where all the members of the namespace were being listed in the detailed documentation in the obsolete members file. Now only the obsolete members are listed there. Change-Id: I757bc4b4a6e32b0b3c2ff5b03624c6d501845063 Task-number: QTBUG-70321 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* | qdoc: Fix generation of namespace documentationTopi Reinio2018-09-061-7/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit a36f925d refactored the Section-related code, resulting in different data structures used for storing sections for C++ classes and namespaces. However, the HTML generator still assumed that the same structure could be used for both, resulting in invalid/no output for namespace documentation. This commit fixes it by selecting the correct vector based on whether we're processing a class or a namespace node. Task-number: QTBUG-70321 Change-Id: Ia80dec9193e22c453350588aba10f4c033f6ba79 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Martin Smith <martin.smith@qt.io>
* | Qt Designer: Fix some remaining clang-tidy warningsFriedemann Kleint2018-09-0311-25/+26
| | | | | | | | | | | | | | | | | | | | - Use QHash instead of QMap for pointer type keys - Use const ref to avoid copies - Fix C-style casts - Add parentheses to macro parameters Change-Id: I74c060fc32c6f7761582d81d219455b1e58c6ff9 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | qdoc: Fix output for shared QML document nodesTopi Reinio2018-08-303-51/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation using SharedCommentNode to collect multiple nodes under a shared documentation (body) was completed only for C++ side (i.e. using multiple \fn commands in a single qdoc comment block). This commit extends the same mechanism to QML, allowing multiple \qmlmethod commands to share a doc. This is already used in a few repositories. Task-number: QTBUG-69692 Change-Id: I85d36ab7424d066a2b23f3338ffd16f0957713ad Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Martin Smith <martin.smith@qt.io>
* | Disable tools that don't make sense on iOSTor Arne Vestbø2018-08-271-3/+3
| | | | | | | | | | | | | | | | | | Until we can build hosts tools (or tools that only make sense to run on the host/development platform, not the target), that have GUI dependencies, we have to exclude the tools completely. Change-Id: If12c5b4bd47a6456f7ae2779a62cca430cf15c3c Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
* | Skip building qdoc if Qt is configured with no-threadEskil Abrahamsen Blomfeldt2018-08-241-1/+1
| | | | | | | | | | | | | | | | | | After the code parser switched to clang, qdoc requires the -pthread compiler flag which is disabled for no-thread builds. Change-Id: I50db3e559569c2e876902dbbedc52127793ff67d Reviewed-by: Lorn Potter <lorn.potter@gmail.com>
* | Introduce distancefieldgeneratorEskil Abrahamsen Blomfeldt2018-08-2213-0/+2107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A tool that allows you to pick prepare .qdf files which are pregenerated distance fields in binary form that can be loaded by Qt to improve startup time. We currently only support cmaps subtable formats 0, 4, 6, 10 and 12, as these are either A. the most commonly used (4 and 12) or B. simple to implement. The tool writes a .ttf file which is a copy of the original file, but with the addition of a "qtdf" table that follows sfnt conventions. This way, the file will work as a normal font file, as well, which means that glyphs that are not in the pregenerated cache can easily be generated at runtime. Task-number: QTBUG-69356 Change-Id: Ib99c2d62f65e65973a60da4b1aa632b7ed3b2794 Reviewed-by: Lars Knoll <lars.knoll@qt.io>
* | Fix division by zeroJesus Fernandez2018-08-201-3/+3
| | | | | | | | | | | | | | | | | | | | | | CID 191124 (#1 of 1): Division or modulo by float zero (DIVIDE_BY_ZERO) 3. divide_by_zero: In expression 60. / (double)numberOfFiles, division by expression numberOfFiles which may be zero has undefined behavior. CID 191125 (#1 of 1): Division or modulo by float zero (DIVIDE_BY_ZERO) 3. divide_by_zero: In expression 27. / (double)numberOfIndices, division by expression numberOfIndices which may be zero has undefined behavior. Change-Id: If4f4a6795c1dfcae904ef7279ab25a1f855a6387 Reviewed-by: Karsten Heimrich <karsten.heimrich@qt.io>
* | Merge remote-tracking branch 'origin/5.11' into devQt Forward Merge Bot2018-08-181-2/+2
|\| | | | | | | Change-Id: Id67ceddd5ee9c7353cba2c3d24564b0168a32651
| * Doc: Fix typo in linguist manualPaul Wicking2018-08-081-2/+2
| | | | | | | | | | | | | | Task-number: QTBUG-51975 Change-Id: Ie7069db3e35a81ea1f44d1bf4c0a2ffd6f3215aa Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
* | Merge remote-tracking branch 'origin/5.11' into devQt Forward Merge Bot2018-08-083-20/+34
|\| | | | | | | | | | | | | Conflicts: .qmake.conf Change-Id: I0edaed2aed9e488ba19bc479e37d91db54fd232c
| * Doc: Update Installing clang for QDoc pagePaul Wicking2018-08-021-12/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | * Remove temporal phrases (e.g. 'at this time', 'at the time of writing') * Remove references to Qt Creator's libclang and questions about static/ dynamic linking in the text. * Describe LLVM and LLVM_INSTALL_DIR environment variable as procedural prerequisites for building QDoc from source. Task-number: QTBUG-69707 Change-Id: I688714b37721ed1180d500674ca4b271ed257799 Reviewed-by: Martin Smith <martin.smith@qt.io>
| * Doc: Add information about locale file name conventionPaul Wicking2018-07-261-6/+17
| | | | | | | | | | | | | | | | | | * Add details from QLocale::QLocale(const QString &name). These have been rewritten to target a less technical audience. Task-number: QTBUG-69556 Change-Id: Ibf08b0b5d6075c4f7ccaf19a3f44bf3ba90433dd Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
| * Linguist: Fix detection of language by filenameKai Koehne2018-07-261-2/+2
| | | | | | | | | | Change-Id: I31c3b259b4ab34c7b43bb08effbc28f4d4f1655f Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
* | Remove unneeded includeJarek Kobus2018-08-021-1/+0
| | | | | | | | | | Change-Id: I7157427501c4c1494d838c035d6cc46c6afa04f9 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* | Qt Designer: Refactor WidgetFactory::isPassiveInteractor()Friedemann Kleint2018-08-012-46/+44
| | | | | | | | | | | | | | | | | | Factor out a helper routine to check on the widget so that the caching pattern becomes clearer. Change the heap-allocated QPointer<QWidget> to a static variable. Change-Id: I5dfc5a9ebc791dbd2e13a9cbde72f77c3e2c6104 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | Qt Designer: Fix clang-tidy warnings about loopsFriedemann Kleint2018-08-0120-91/+54
| | | | | | | | | | | | | | - Replace index-based loops by range-based for Change-Id: I074a52631cbf5233e1c762cee99064b8897abc30 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | Qt Designer: Fix clang-tidy warnings about if / return statementsFriedemann Kleint2018-07-3131-217/+193
| | | | | | | | | | | | | | | | | | | | - Simplify/streamline if statmenents (comparison against bool literal) - Change else if to if after return/break/continue - Fix indentation - Do not check for non-null before invoking delete on pointer Change-Id: I1b803b01cffd56b3f11e63c3e2e7ae103b1d8799 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | Qt Designer: Fix clang-tidy warnings about Qt usageFriedemann Kleint2018-07-3123-49/+87
| | | | | | | | | | | | | | | | | | | | | | - Use multi-arg form of QString::arg() - Fix static method calls - Prefer QFileInfo::exists() - Use isEmpty() for containers instead of checking size() - Use QOverload Change-Id: I31e92f77d0fa377932c1369afe2503abc8ecceac Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | Qt Designer: Refactor FormWindowManager::getUnsortedLayoutsToBeBroken()Friedemann Kleint2018-07-312-8/+7
| | | | | | | | | | | | | | | | | | Change the return type from a QMap<QWidget *,bool> to a QSet<QWidget *> to fix a clang-tidy warning that a QHash should be used. The bool is redundant, though. Change-Id: Ib0bced9166cb6050e48195851abd6cb2b5109537 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | Qt Designer: Fix clang-tidy warnings about class definitionsFriedemann Kleint2018-07-31151-444/+309
| | | | | | | | | | | | | | | | | | | | | | - Use ' = default' for trivial constructors/destructors - replace virtual by override or add override where applicable - Return *this from assignment operators of custom iterators - Replace trivial constructors by member initialization for simple structs - Add Q_DISABLE_COPY Change-Id: I67fb07cb82ccba93a41d58a8a0782628c9c681d9 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | qdoc: Fix generated C++ and QML type listsTopi Reinio2018-07-311-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As of change 03b8f9d9, for nodes read from an index, QDoc creates a Doc instance that evaluates as empty (Node::hasDoc() returns false). This resulted in 'All C++ Classes' and 'All QML Types' pages to have no content as the code that selects the listed nodes had a check against an empty Doc. Remove this check as unnecessary: for a type to be listed it's enough for it to be marked as public. Task-number: QTBUG-69693 Change-Id: I35a61c99ef3d44023601705be26e74e695cd1d0e Reviewed-by: Martin Smith <martin.smith@qt.io>
* | qdoc: Allow macro expansion in qdoc command argumentsTopi Reinio2018-07-311-37/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Until now, QDoc did not expand macros if they were used in arguments for other commands. Macros can be useful in command arguments, for example: \qmlmodule QtQuick 2.\qtminorversion where \qtminorversion expands to the current minor version, or \title \productname Manual where \productname expands to the current product name. Task-number: QTBUG-67818 Change-Id: Ib3e2da9f6bd20343a454f467742cfa00ee09b39a Reviewed-by: Martin Smith <martin.smith@qt.io>
* | Doc: Add targets for lupdate and lreleaseKai Koehne2018-07-261-0/+2
| | | | | | | | | | | | | | | | | | So that they can easily be interlinked in other parts of the documentation. Change-Id: Iddacd2f53121f41b1bf7ea4d24bdd16e9fb2c22c Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
* | Remove the QHelpDataInterface base classJarek Kobus2018-07-264-34/+20
| | | | | | | | | | Change-Id: I249d871bc437ad42b8b6ecbf95b19ba5520fdf74 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* | Unexport HelpProjectData and move it to helpgenerator app treeJarek Kobus2018-07-269-20/+18
| | | | | | | | | | Change-Id: I5af687d5f7dd3fc886a33453b5613df062a8f5a2 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* | Merge qcollectiongenerator into qhelpgenerator toolJarek Kobus2018-07-2612-707/+681
| | | | | | | | | | Change-Id: I3c961d7c13ce4f9a3aa36dd0554ec5184fbc5953 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* | Qt Designer: Simplify the form version checking codeFriedemann Kleint2018-07-251-17/+5
| | | | | | | | | | | | | | Replace parsing by QVersionNumber. Change-Id: I793a30f7d5746ea3f2644be94a2a57fbfb0f2769 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | QUiLoader: Refactor QAbstractFormBuilder::applyTabStops()Friedemann Kleint2018-07-251-21/+13
| | | | | | | | | | | | | | | | | | | | Collect all widgets before applying the order and bail out if one cannot be found. The algorithm cannot do any meaningful if one is missing. Change the loop applying the order to a one-liner. Change-Id: I52a2d7e8252d346f6d697889e796c76f114a56f2 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | Merge remote-tracking branch 'origin/5.11' into devFriedemann Kleint2018-07-2510-102/+143
|\| | | | | | | Change-Id: I08932d5a2599831a4cc53f5a70709d7c3a27a35b
| * Make the "Copyright" field in attribution files optionalNicolas Ettlin2018-07-241-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | Currently, the "Copyright" field in copyright attribution files is mandatory. However, this obligation should be lifted so we could later use README.chromium files with the qtattributionscanner tool (these files do not contain a Copyright field ; in these cases, the copyright owners can be found in the license file's body). Change-Id: I569f8cd5d3f20fc85e5fcb873601053327841dda Reviewed-by: Kai Koehne <kai.koehne@qt.io> Reviewed-by: hjk <hjk@qt.io>
| * Doc: Exclude parts of QtUiTools documentation based on the qdoc configVenugopal Shivashankar2018-07-242-0/+4
| | | | | | | | | | Change-Id: I4b0257108498efa2e10a1c4fa5deda3acb74187f Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
| * QDoc: Check aggregates with Node::nodeNameLessThan to improve sortingPaul Wicking2018-07-181-11/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Certain corner cases were not covered by the current implementation, causing the sort to fail. This change aims to make QDoc capable of sorting all nodes derived from aggregate, because an aggregate can be expected to have a user visible title that can be used to sort content alphabetically. Impressively, this has been working for most lists of classes in the generated docs, just not all. Task-number: QTBUG-67530 Change-Id: I5b5b19011c6a1e561894f8155c971da60aff7e2f Reviewed-by: Topi Reiniö <topi.reinio@qt.io> Reviewed-by: Martin Smith <martin.smith@qt.io>
| * Qt Designer: Fix Qt Creator crashes on reloading malformed UI filesFriedemann Kleint2018-07-106-87/+137
| | | | | | | | | | | | | | | | | | | | | | | | Extract the functionality to read the DomUI with version check to QFormBuilderExtra so that the reading can be split into DomUI and widget creation. In FormWindow, check the success of the DomUI creation before modifying Qt Designer's internal state. Task-number: QTCREATORBUG-20742 Change-Id: I095f80e90966eba67d8994cd68e83c3e11aa0ee9 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
* | Qt Designer: Modernize the ui4.cpp/.h filesFriedemann Kleint2018-07-242-440/+371
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Silence clang-tidy warnings in the generated files - use nullptr [modernize-use-nullptr]: Use nullptr where applicable and simplify the switch() statement in write() on this occasion to use member variables instead of accessors. - use '= default' to define a trivial destructor [modernize-use-equals-default] Check if any delete statements are required. If not, use "= default". - use auto when initializing with new to avoid duplicating the type name [modernize-use-auto] Use auto. Change-Id: I48abfd8719b1ee66d68014cc02038a7decb70d4c Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>