From 844d7582dc73ec0ec11f939cc1cf9e4abb4786e8 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 5 Apr 2019 12:45:08 +0200 Subject: Fix a crash when closing the Manage Bookmarks dialog Before, we have deleted the bookmarks dialog directly from it's closeEvent. It means that its closeEvent invocation wasn't finished yet -> crash. We use deleteLater now instead. Task-number: QTBUG-72218 Change-Id: Ia83f9d2027a63ccaccebe22a8e5d92e808bec2bd Reviewed-by: Alessandro Portale --- src/assistant/assistant/bookmarkmanager.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/assistant/assistant/bookmarkmanager.cpp b/src/assistant/assistant/bookmarkmanager.cpp index f15e23a6e..331cea864 100644 --- a/src/assistant/assistant/bookmarkmanager.cpp +++ b/src/assistant/assistant/bookmarkmanager.cpp @@ -526,7 +526,8 @@ void BookmarkManager::focusInEventOccurred() void BookmarkManager::managerWidgetAboutToClose() { - delete bookmarkManagerWidget; + if (bookmarkManagerWidget) + bookmarkManagerWidget->deleteLater(); bookmarkManagerWidget = nullptr; storeBookmarks(); -- cgit v1.2.3