From 9e1bc9718d66afe9bf5bbb92d5bb6d3538dc037b Mon Sep 17 00:00:00 2001 From: Paul Wicking Date: Wed, 18 Sep 2019 14:09:17 +0200 Subject: Simplify loops in codeparser.cpp Use range-based for loops for more expressive code. Use qAsConst on static non-const containers in loops that are not supposed to modify the container. Change-Id: I3f1083880de7f8b922eb7a5378482f352ebcec39 Reviewed-by: Martin Smith --- src/qdoc/codeparser.cpp | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/src/qdoc/codeparser.cpp b/src/qdoc/codeparser.cpp index a3c93ca4c..3453f0b18 100644 --- a/src/qdoc/codeparser.cpp +++ b/src/qdoc/codeparser.cpp @@ -98,11 +98,8 @@ void CodeParser::parseHeaderFile(const Location &location, const QString &filePa */ void CodeParser::initialize(const Config &config) { - QList::ConstIterator p = parsers.constBegin(); - while (p != parsers.constEnd()) { - (*p)->initializeParser(config); - ++p; - } + for (const auto &parser : qAsConst(parsers)) + parser->initializeParser(config); } /*! @@ -110,20 +107,15 @@ void CodeParser::initialize(const Config &config) */ void CodeParser::terminate() { - QList::ConstIterator p = parsers.constBegin(); - while (p != parsers.constEnd()) { - (*p)->terminateParser(); - ++p; - } + for (const auto parser : parsers) + parser->terminateParser(); } CodeParser *CodeParser::parserForLanguage(const QString &language) { - QList::ConstIterator p = parsers.constBegin(); - while (p != parsers.constEnd()) { - if ((*p)->language() == language) - return *p; - ++p; + for (const auto parser : qAsConst(parsers)) { + if (parser->language() == language) + return parser; } return nullptr; } -- cgit v1.2.3