diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-04-17 11:13:54 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-04-17 09:38:49 +0000 |
| commit | 14f4ea59491e40e7f95df9d7307433ef2c249ab5 (patch) | |
| tree | a46641582a7238f92167679d07466decaffb5e4a | |
| parent | 5a0e9ea5237f9c566620984934231382f8c925af (diff) | |
OpenWnnInputMethodPrivate::displayCandidates(): Add parentheses to assignment in condition
Fix clang-cl warning:
openwnninputmethod.cpp:312: using the result of an assignment as a condition without parentheses [-Wparentheses]
Drop unneeded braces on that occasion.
Task-number: QTBUG-63512
Change-Id: Ie9137bedf07d6728282be554fb21893246ae1e96
Reviewed-by: Jarkko Koivikko <jarkko.koivikko@code-q.fi>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
| -rw-r--r-- | src/virtualkeyboard/openwnninputmethod.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/virtualkeyboard/openwnninputmethod.cpp b/src/virtualkeyboard/openwnninputmethod.cpp index d94f212a..2c265d00 100644 --- a/src/virtualkeyboard/openwnninputmethod.cpp +++ b/src/virtualkeyboard/openwnninputmethod.cpp @@ -309,9 +309,8 @@ public: clearCandidates(true); QSharedPointer<WnnWord> result; - while (result = converter->getNextCandidate()) { + while ((result = converter->getNextCandidate())) candidateList.append(result); - } Q_Q(OpenWnnInputMethod); if (!candidateList.isEmpty() || !wasEmpty) |