From 7962eee50b83a58dcbbfd6dc94fc0a1bec87df01 Mon Sep 17 00:00:00 2001 From: Jarkko Koivikko Date: Wed, 20 Apr 2022 16:27:24 +0300 Subject: Revert "Fix broken layout that results from making key visible after startup" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 13a199e6e2c5f27b0f12eff380df4f0c0d156e6e. Reverting this change because the layout optimization change in qtdeclarative: 10e359fa0b567534741b8a2550a336dffaf7a68f would otherwise break virtual keyboard layout. Fixes: QTBUG-102737 Change-Id: I4664161cf8cacb70e47d55d766dc53780fe00d28 Reviewed-by: Qt CI Bot Reviewed-by: Mitch Curtis Reviewed-by: Jan Arve Sæther --- src/components/BaseKey.qml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/components/BaseKey.qml b/src/components/BaseKey.qml index 945e8a70..af2adee2 100644 --- a/src/components/BaseKey.qml +++ b/src/components/BaseKey.qml @@ -255,13 +255,6 @@ Item { onSoundEffectChanged: keyboard.soundEffect.register(soundEffect) - // QTBUG-54953, QTBUG-55773 - // Avoid a row that was hidden taking up the entire height of the - // keyboard when it is made visible after the application has started. - // This value is low because keys can scale vertically, and setting e.g. 40 - // pixels might be too high for a keyboard that doesn't have a lot of space. - implicitHeight: 1 - Layout.minimumWidth: keyPanel.implicitWidth Layout.minimumHeight: keyPanel.implicitHeight Layout.preferredWidth: weight -- cgit v1.2.3