diff options
author | Weng Xuetian <wengxt@gmail.com> | 2024-02-11 15:30:42 -0800 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2024-02-13 03:00:16 +0000 |
commit | af58a577ef59dea18402f3fb1f940e7a042153cf (patch) | |
tree | 51162a4983a0db614ba3dd629dbdd7322d1d4a51 | |
parent | 6e6375510f7ae1d27c9c25dbe3da0edacb02395f (diff) |
Prefer text-input-v2 over text-input-v3 for now
Qt's current text-input-v3 is converted from text-input-v4, but it's
current state is poor and does not support the same feature like v2.
KWin is the only major party that implements text-input-v2 and many
feature e.g. Plasma-mobile would require v2 feature to provide the
complete support. Until v3 is as good as v2, prefer v2 over v3 should
provide a smoother experience on KWin (for both 5/6) out of box and
won't affect other compositor.
Change-Id: Iebfe20cfd61f4a96018c4d41a9c4c706b18c7199
Reviewed-by: David Edmundson <davidedmundson@kde.org>
(cherry picked from commit 7e6d6f207b54af9c397a0b2bbc380a02d2975ce0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r-- | src/client/qwaylanddisplay.cpp | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/client/qwaylanddisplay.cpp b/src/client/qwaylanddisplay.cpp index 8ca4effb6..6c3df2196 100644 --- a/src/client/qwaylanddisplay.cpp +++ b/src/client/qwaylanddisplay.cpp @@ -553,13 +553,17 @@ void QWaylandDisplay::blockingReadEvents() void QWaylandDisplay::checkTextInputProtocol() { QStringList tips, timps; // for text input protocols and text input manager protocols + // zwp_text_input_v2 is preferred over zwp_text_input_v3 because: + // - Currently, v3 is not as feature rich as v2. + // - While v2 is not upstreamed, it is well supported by KWin since Plasma 5 and Plasma + // Mobile uses some v2 only. tips << QLatin1String(QtWayland::qt_text_input_method_v1::interface()->name) - << QLatin1String(QtWayland::zwp_text_input_v3::interface()->name) << QLatin1String(QtWayland::zwp_text_input_v2::interface()->name) + << QLatin1String(QtWayland::zwp_text_input_v3::interface()->name) << QLatin1String(QtWayland::zwp_text_input_v1::interface()->name); timps << QLatin1String(QtWayland::qt_text_input_method_manager_v1::interface()->name) - << QLatin1String(QtWayland::zwp_text_input_manager_v3::interface()->name) << QLatin1String(QtWayland::zwp_text_input_manager_v2::interface()->name) + << QLatin1String(QtWayland::zwp_text_input_manager_v3::interface()->name) << QLatin1String(QtWayland::zwp_text_input_manager_v1::interface()->name); QString tiProtocols = QString::fromLocal8Bit(qgetenv("QT_WAYLAND_TEXT_INPUT_PROTOCOL")); |