diff options
| author | Johan Klokkhammer Helsing <johan.helsing@qt.io> | 2018-02-27 11:32:15 +0100 |
|---|---|---|
| committer | Johan Helsing <johan.helsing@qt.io> | 2018-02-27 17:03:41 +0000 |
| commit | c4bd9198b4a0fac809903dd2c09276c2c3c1b22e (patch) | |
| tree | 83325fe11d258c922ede480e0ad3de3df45032fa /examples/wayland/custom-extension | |
| parent | 72999738489b5251d025c954a77c93e8e1fdfd9d (diff) | |
Init variables where they are declared when possible (clang-tidy)
clang-tidy -p compile_commands.json $file \
-checks='-*,modernize-use-default-member-init,readability-redundant-member-init' \
-config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' \
-header-filter='qtwayland' \
-fix
Afterwards I ran search and replace on the diff to clean up some whitespace errors:
- Replaced '(\n\+[^:\n]*)(:\s+\+\s+)' with '$1: '
- Replaced '(\n\+[^,\n]*)(,\s+\+\s+)' with '$1, '
- Replaced '\n\+\s*\n' with '\n'
I also had to do some manual edits, because for some reason, this particular
clang-tidy check doesn't trigger for some files.
Change-Id: I3b3909bac4bf20108bbe8ad1e01bcc54236dae1b
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Diffstat (limited to 'examples/wayland/custom-extension')
| -rw-r--r-- | examples/wayland/custom-extension/client-common/customextension.cpp | 1 | ||||
| -rw-r--r-- | examples/wayland/custom-extension/client-common/customextension.h | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/examples/wayland/custom-extension/client-common/customextension.cpp b/examples/wayland/custom-extension/client-common/customextension.cpp index 41b4a30e9..90e1f4377 100644 --- a/examples/wayland/custom-extension/client-common/customextension.cpp +++ b/examples/wayland/custom-extension/client-common/customextension.cpp @@ -61,7 +61,6 @@ QT_BEGIN_NAMESPACE CustomExtension::CustomExtension() : QWaylandClientExtensionTemplate(/* Supported protocol version */ 1 ) - , m_activated(false) { connect(this, &CustomExtension::activeChanged, this, &CustomExtension::handleExtensionActive); } diff --git a/examples/wayland/custom-extension/client-common/customextension.h b/examples/wayland/custom-extension/client-common/customextension.h index 003a5a008..5e48ea75e 100644 --- a/examples/wayland/custom-extension/client-common/customextension.h +++ b/examples/wayland/custom-extension/client-common/customextension.h @@ -93,7 +93,7 @@ private: void sendWindowRegistration(QWindow *); QList<QWindow *> m_windows; - bool m_activated; + bool m_activated = false; }; class CustomExtensionObject : public QWaylandClientExtensionTemplate<CustomExtensionObject> |