Init variables where they are declared when possible (clang-tidy)

clang-tidy -p compile_commands.json $file \
    -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' \
    -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' \
    -header-filter='qtwayland' \
    -fix

Afterwards I ran search and replace on the diff to clean up some whitespace errors:

- Replaced '(\n\+[^:\n]*)(:\s+\+\s+)' with '$1: '
- Replaced '(\n\+[^,\n]*)(,\s+\+\s+)' with '$1, '
- Replaced '\n\+\s*\n' with '\n'

I also had to do some manual edits, because for some reason, this particular
clang-tidy check doesn't trigger for some files.

Change-Id: I3b3909bac4bf20108bbe8ad1e01bcc54236dae1b
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>

1 files changed, 8 insertions, 8 deletions

diff --git a/src/client/qwaylandscreen_p.h b/src/client/qwaylandscreen_p.h
index 674e1a913..37c35cfff 100644
--- a/src/client/qwaylandscreen_p.h
+++ b/src/client/qwaylandscreen_p.h
@@ -116,21 +116,21 @@ private:
     void output_done() override;
 
     int m_outputId;
-    QWaylandDisplay *mWaylandDisplay;
+    QWaylandDisplay *mWaylandDisplay = nullptr;
     QString mManufacturer;
     QString mModel;
     QRect mGeometry;
-    int mScale;
-    int mDepth;
-    int mRefreshRate;
-    int mTransform;
-    QImage::Format mFormat;
+    int mScale = 1;
+    int mDepth = 32;
+    int mRefreshRate = 60000;
+    int mTransform = -1;
+    QImage::Format mFormat = QImage::Format_ARGB32_Premultiplied;
     QSize mPhysicalSize;
     QString mOutputName;
-    Qt::ScreenOrientation m_orientation;
+    Qt::ScreenOrientation m_orientation = Qt::PrimaryOrientation;
 
 #if QT_CONFIG(cursor)
-    QWaylandCursor *mWaylandCursor;
+    QWaylandCursor *mWaylandCursor = nullptr;
 #endif
 };