diff options
author | Paul Olav Tvete <paul.tvete@theqtcompany.com> | 2015-09-07 16:21:19 +0200 |
---|---|---|
committer | Frederik Gladhorn <frederik.gladhorn@theqtcompany.com> | 2015-09-08 10:48:08 +0000 |
commit | 0bd742ca93eca63305b9aaade78b14b202f34dfa (patch) | |
tree | 1aab6171679f0926df3360209d42ef82c7687616 /src/compositor/compositor_api/qwaylandoutput.cpp | |
parent | 6358b0ede93c6633802126bf8bf0a44860e66917 (diff) |
Fix crash in pickView()
...this is why we need autotests for all functions
Change-Id: I73aa6ac1777684ceac51a59884b059871c18d260
Reviewed-by: Jørgen Lind <jorgen.lind@theqtcompany.com>
Diffstat (limited to 'src/compositor/compositor_api/qwaylandoutput.cpp')
-rw-r--r-- | src/compositor/compositor_api/qwaylandoutput.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/compositor/compositor_api/qwaylandoutput.cpp b/src/compositor/compositor_api/qwaylandoutput.cpp index 0496cb96b..f35e6e7d9 100644 --- a/src/compositor/compositor_api/qwaylandoutput.cpp +++ b/src/compositor/compositor_api/qwaylandoutput.cpp @@ -569,12 +569,12 @@ void QWaylandOutput::surfaceLeave(QWaylandSurface *surface) QWaylandView *QWaylandOutput::pickView(const QPointF &outputPosition) const { Q_D(const QWaylandOutput); - for (int nSurface = 0; d->surfaceViews.size(); nSurface++) { + for (int nSurface = 0; nSurface < d->surfaceViews.size(); nSurface++) { const QWaylandSurface *surface = d->surfaceViews.at(nSurface).surface; if (surface->isCursorSurface()) continue; const QVector<QWaylandView *> views = d->surfaceViews.at(nSurface).views; - for (int nView = 0; views.size(); nView++) { + for (int nView = 0; nView < views.size(); nView++) { if (QRectF(views.at(nView)->requestedPosition(), surface->size()).contains(outputPosition)) return views.at(nView); } |