Init variables where they are declared when possible (clang-tidy)

clang-tidy -p compile_commands.json $file \
    -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' \
    -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' \
    -header-filter='qtwayland' \
    -fix

Afterwards I ran search and replace on the diff to clean up some whitespace errors:

- Replaced '(\n\+[^:\n]*)(:\s+\+\s+)' with '$1: '
- Replaced '(\n\+[^,\n]*)(,\s+\+\s+)' with '$1, '
- Replaced '\n\+\s*\n' with '\n'

I also had to do some manual edits, because for some reason, this particular
clang-tidy check doesn't trigger for some files.

Change-Id: I3b3909bac4bf20108bbe8ad1e01bcc54236dae1b
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>

1 files changed, 2 insertions, 4 deletions

diff --git a/src/imports/compositor/qwaylandmousetracker.cpp b/src/imports/compositor/qwaylandmousetracker.cpp
index 99adef5bf..a39aa0bea 100644
--- a/src/imports/compositor/qwaylandmousetracker.cpp
+++ b/src/imports/compositor/qwaylandmousetracker.cpp
@@ -48,8 +48,6 @@ class QWaylandMouseTrackerPrivate : public QQuickItemPrivate
     Q_DECLARE_PUBLIC(QWaylandMouseTracker)
 public:
     QWaylandMouseTrackerPrivate()
-        : windowSystemCursorEnabled(false)
-        , hovered(false)
     {
         QImage cursorImage(64,64,QImage::Format_ARGB32);
         cursorImage.fill(Qt::transparent);
@@ -79,9 +77,9 @@ public:
     }
 
     QPointF mousePos;
-    bool windowSystemCursorEnabled;
+    bool windowSystemCursorEnabled = false;
     QPixmap cursorPixmap;
-    bool hovered;
+    bool hovered = false;
 };
 
 QWaylandMouseTracker::QWaylandMouseTracker(QQuickItem *parent)