Init variables where they are declared when possible (clang-tidy)

clang-tidy -p compile_commands.json $file \
    -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' \
    -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' \
    -header-filter='qtwayland' \
    -fix

Afterwards I ran search and replace on the diff to clean up some whitespace errors:

- Replaced '(\n\+[^:\n]*)(:\s+\+\s+)' with '$1: '
- Replaced '(\n\+[^,\n]*)(,\s+\+\s+)' with '$1, '
- Replaced '\n\+\s*\n' with '\n'

I also had to do some manual edits, because for some reason, this particular
clang-tidy check doesn't trigger for some files.

Change-Id: I3b3909bac4bf20108bbe8ad1e01bcc54236dae1b
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>

3 files changed, 3 insertions, 6 deletions

diff --git a/src/plugins/platforms/qwayland-egl/qwaylandeglplatformintegration.h b/src/plugins/platforms/qwayland-egl/qwaylandeglplatformintegration.h
index dde430381..625583913 100644
--- a/src/plugins/platforms/qwayland-egl/qwaylandeglplatformintegration.h
+++ b/src/plugins/platforms/qwayland-egl/qwaylandeglplatformintegration.h
@@ -52,8 +52,7 @@ class QWaylandEglPlatformIntegration : public QWaylandIntegration
 {
 public:
     QWaylandEglPlatformIntegration()
-        : QWaylandIntegration()
-        , m_client_buffer_integration(new QWaylandEglClientBufferIntegration())
+        : m_client_buffer_integration(new QWaylandEglClientBufferIntegration())
     {
         m_client_buffer_integration->initialize(display());
     }
diff --git a/src/plugins/platforms/qwayland-xcomposite-egl/qwaylandxcompositeeglplatformintegration.h b/src/plugins/platforms/qwayland-xcomposite-egl/qwaylandxcompositeeglplatformintegration.h
index 009a12f67..e711133c0 100644
--- a/src/plugins/platforms/qwayland-xcomposite-egl/qwaylandxcompositeeglplatformintegration.h
+++ b/src/plugins/platforms/qwayland-xcomposite-egl/qwaylandxcompositeeglplatformintegration.h
@@ -52,8 +52,7 @@ class QWaylandXCompositeEglPlatformIntegration : public QWaylandIntegration
 {
 public:
     QWaylandXCompositeEglPlatformIntegration()
-        : QWaylandIntegration()
-        , m_client_buffer_integration(new QWaylandXCompositeEGLClientBufferIntegration())
+        : m_client_buffer_integration(new QWaylandXCompositeEGLClientBufferIntegration())
     {
         m_client_buffer_integration->initialize(display());
     }
diff --git a/src/plugins/platforms/qwayland-xcomposite-glx/qwaylandxcompositeglxplatformintegration.h b/src/plugins/platforms/qwayland-xcomposite-glx/qwaylandxcompositeglxplatformintegration.h
index a8a70bdd9..32e286c52 100644
--- a/src/plugins/platforms/qwayland-xcomposite-glx/qwaylandxcompositeglxplatformintegration.h
+++ b/src/plugins/platforms/qwayland-xcomposite-glx/qwaylandxcompositeglxplatformintegration.h
@@ -53,8 +53,7 @@ class QWaylandXCompositeGlxPlatformIntegration : public QWaylandIntegration
 {
 public:
     QWaylandXCompositeGlxPlatformIntegration()
-        : QWaylandIntegration()
-        , m_client_buffer_integration(new QWaylandXCompositeGLXIntegration())
+        : m_client_buffer_integration(new QWaylandXCompositeGLXIntegration())
     {
         m_client_buffer_integration->initialize(display());
     }