diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-01-22 13:14:41 +0100 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-05-23 13:31:33 +0200 |
commit | a8319f6aea3a14e60c23d4f14a681519aa78669d (patch) | |
tree | f79b8252891b1aaef58d1f7947d6a78a0fd549f5 | |
parent | 7b570c48dd40d218a3061964356f69fa769b85b7 (diff) |
Make optimize_for_size an arg again
Otherwise we can not configure it.
Change-Id: If2900e9f142c945c921df46be21e7eb14ee2d1cb
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
-rw-r--r-- | chromium/build/config/compiler/compiler.gni | 29 |
1 files changed, 15 insertions, 14 deletions
diff --git a/chromium/build/config/compiler/compiler.gni b/chromium/build/config/compiler/compiler.gni index 60f05de82fd..5295f10d7ef 100644 --- a/chromium/build/config/compiler/compiler.gni +++ b/chromium/build/config/compiler/compiler.gni @@ -67,20 +67,21 @@ declare_args() { assert(!is_cfi || use_thin_lto, "CFI requires ThinLTO") -# Exclude unwind tables for official builds as unwinding can be done from stack -# dumps produced by Crashpad at a later time "offline" in the crash server. -# For unofficial (e.g. development) builds and non-Chrome branded (e.g. Cronet -# which doesn't use Crashpad, crbug.com/479283) builds it's useful to be able -# to unwind at runtime. -exclude_unwind_tables = - (is_chrome_branded && is_official_build) || - (is_chromecast && !is_cast_desktop_build && !is_debug && !is_fuchsia) - -# If true, optimize for size. Does not affect windows builds. -# Linux & Mac favor speed over size. -# TODO(brettw) it's weird that Mac and desktop Linux are different. We should -# explore favoring size over speed in this case as well. -optimize_for_size = is_android || is_ios +declare_args() { + # Exclude unwind tables for official builds as unwinding can be done from stack + # dumps produced by Crashpad at a later time "offline" in the crash server. + # For unofficial (e.g. development) builds and non-Chrome branded (e.g. Cronet + # which doesn't use Crashpad, crbug.com/479283) builds it's useful to be able + # to unwind at runtime. + exclude_unwind_tables = (is_chrome_branded && is_official_build) || + (is_chromecast && !is_cast_desktop_build && !is_debug && !is_fuchsia) + + # If true, optimize for size. Does not affect windows builds. + # Linux & Mac favor speed over size. + # TODO(brettw) it's weird that Mac and desktop Linux are different. We should + # explore favoring size over speed in this case as well. + optimize_for_size = is_android || is_ios +} declare_args() { # Whether we should consider the profile we're using to be accurate. Accurate |