diff options
Diffstat (limited to 'chromium/chrome/browser/resources/settings/search_settings.js')
-rw-r--r-- | chromium/chrome/browser/resources/settings/search_settings.js | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/chromium/chrome/browser/resources/settings/search_settings.js b/chromium/chrome/browser/resources/settings/search_settings.js index a98f501303f..60facec8de0 100644 --- a/chromium/chrome/browser/resources/settings/search_settings.js +++ b/chromium/chrome/browser/resources/settings/search_settings.js @@ -149,11 +149,15 @@ cr.define('settings', function() { let associatedControl = null; // Find corresponding SETTINGS-SECTION parent and make it visible. let parent = node; - while (parent && parent.nodeName !== 'SETTINGS-SECTION') { + while (parent.nodeName !== 'SETTINGS-SECTION') { parent = parent.nodeType == Node.DOCUMENT_FRAGMENT_NODE ? parent.host : parent.parentNode; - if (parent && parent.nodeName == 'SETTINGS-SUBPAGE') { + if (!parent) { + // |node| wasn't inside a SETTINGS-SECTION. + return null; + } + if (parent.nodeName == 'SETTINGS-SUBPAGE') { // TODO(dpapad): Cast to SettingsSubpageElement here. associatedControl = assert( parent.associatedControl, @@ -161,9 +165,7 @@ cr.define('settings', function() { parent.pageTitle + ', but was not found.'); } } - if (parent) { - parent.hiddenBySearch = false; - } + parent.hiddenBySearch = false; // Need to add the search bubble after the parent SETTINGS-SECTION has // become visible, otherwise |offsetWidth| returns zero. |