diff options
Diffstat (limited to 'chromium/chrome/browser/ui/webui/snippets_internals')
4 files changed, 4 insertions, 8 deletions
diff --git a/chromium/chrome/browser/ui/webui/snippets_internals/BUILD.gn b/chromium/chrome/browser/ui/webui/snippets_internals/BUILD.gn index 0575b4b15d2..f83f5c25536 100644 --- a/chromium/chrome/browser/ui/webui/snippets_internals/BUILD.gn +++ b/chromium/chrome/browser/ui/webui/snippets_internals/BUILD.gn @@ -8,7 +8,4 @@ mojom("mojo_bindings") { sources = [ "snippets_internals.mojom", ] - - # TODO(https://crbug.com/968369): Change to use new names. - use_old_js_lite_bindings_names = true } diff --git a/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_page_handler.cc b/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_page_handler.cc index 82628d37081..2bcda35f859 100644 --- a/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_page_handler.cc +++ b/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_page_handler.cc @@ -117,8 +117,7 @@ SnippetsInternalsPageHandler::SnippetsInternalsPageHandler( content_suggestions_service_ ->remote_suggestions_provider_for_debugging()), pref_service_(pref_service), - page_(std::move(page)), - weak_ptr_factory_(this) {} + page_(std::move(page)) {} SnippetsInternalsPageHandler::~SnippetsInternalsPageHandler() {} diff --git a/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_page_handler.h b/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_page_handler.h index e2ab4c8cbb3..7702050a60e 100644 --- a/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_page_handler.h +++ b/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_page_handler.h @@ -92,7 +92,7 @@ class SnippetsInternalsPageHandler // Handle back to the page by which we can update. snippets_internals::mojom::PagePtr page_; - base::WeakPtrFactory<SnippetsInternalsPageHandler> weak_ptr_factory_; + base::WeakPtrFactory<SnippetsInternalsPageHandler> weak_ptr_factory_{this}; DISALLOW_COPY_AND_ASSIGN(SnippetsInternalsPageHandler); }; diff --git a/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_ui.cc b/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_ui.cc index cfe01dc50f0..89f723083ee 100644 --- a/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_ui.cc +++ b/chromium/chrome/browser/ui/webui/snippets_internals/snippets_internals_ui.cc @@ -53,9 +53,9 @@ void SnippetsInternalsUI::CreatePageHandler( CreatePageHandlerCallback callback) { DCHECK(page); snippets_internals::mojom::PageHandlerPtr handler; - page_handler_.reset(new SnippetsInternalsPageHandler( + page_handler_ = std::make_unique<SnippetsInternalsPageHandler>( mojo::MakeRequest(&handler), std::move(page), - content_suggestions_service_, pref_service_)); + content_suggestions_service_, pref_service_); std::move(callback).Run(std::move(handler)); } |