diff options
Diffstat (limited to 'chromium/components/previews/content/previews_hints_unittest.cc')
-rw-r--r-- | chromium/components/previews/content/previews_hints_unittest.cc | 29 |
1 files changed, 11 insertions, 18 deletions
diff --git a/chromium/components/previews/content/previews_hints_unittest.cc b/chromium/components/previews/content/previews_hints_unittest.cc index 474cf0159c9..9fa246bedb0 100644 --- a/chromium/components/previews/content/previews_hints_unittest.cc +++ b/chromium/components/previews/content/previews_hints_unittest.cc @@ -259,32 +259,27 @@ TEST_F(PreviewsHintsTest, LogHintCacheMatch) { 5 /* EFFECTIVE_CONNECTION_TYPE_4G */, 1); } -TEST_F(PreviewsHintsTest, IsBlacklisted) { +TEST_F(PreviewsHintsTest, IsBlacklistedReturnsTrueIfNoBloomFilter) { base::test::ScopedFeatureList scoped_list; scoped_list.InitAndEnableFeature(features::kLitePageServerPreviews); - BloomFilter blacklist_bloom_filter(kBlackBlacklistBloomFilterNumHashFunctions, - kBlackBlacklistBloomFilterNumBits); - PopulateBlackBlacklistBloomFilter(&blacklist_bloom_filter); - optimization_guide::proto::Configuration config; - AddBlacklistBloomFilterToConfig(blacklist_bloom_filter, - kBlackBlacklistBloomFilterNumHashFunctions, - kBlackBlacklistBloomFilterNumBits, &config); ParseConfig(config); - EXPECT_TRUE(HasLitePageRedirectBlacklist()); + EXPECT_FALSE(HasLitePageRedirectBlacklist()); + EXPECT_FALSE(previews_hints()->IsBlacklisted(GURL("https://black.com/path"), PreviewsType::LOFI)); + EXPECT_TRUE(previews_hints()->IsBlacklisted( GURL("https://black.com/path"), PreviewsType::LITE_PAGE_REDIRECT)); EXPECT_TRUE(previews_hints()->IsBlacklisted( GURL("https://joe.black.com/path"), PreviewsType::LITE_PAGE_REDIRECT)); - EXPECT_FALSE(previews_hints()->IsBlacklisted( + EXPECT_TRUE(previews_hints()->IsBlacklisted( GURL("https://nonblack.com"), PreviewsType::LITE_PAGE_REDIRECT)); } -TEST_F(PreviewsHintsTest, IgnoreLitePageRedirectBlacklist) { +TEST_F(PreviewsHintsTest, IsBlacklisted) { base::test::ScopedFeatureList scoped_list; scoped_list.InitAndEnableFeature(features::kLitePageServerPreviews); @@ -298,14 +293,12 @@ TEST_F(PreviewsHintsTest, IgnoreLitePageRedirectBlacklist) { kBlackBlacklistBloomFilterNumBits, &config); ParseConfig(config); - base::CommandLine::ForCurrentProcess()->AppendSwitch( - switches::kIgnoreLitePageRedirectOptimizationBlacklist); - + EXPECT_TRUE(HasLitePageRedirectBlacklist()); EXPECT_FALSE(previews_hints()->IsBlacklisted(GURL("https://black.com/path"), PreviewsType::LOFI)); - EXPECT_FALSE(previews_hints()->IsBlacklisted( + EXPECT_TRUE(previews_hints()->IsBlacklisted( GURL("https://black.com/path"), PreviewsType::LITE_PAGE_REDIRECT)); - EXPECT_FALSE(previews_hints()->IsBlacklisted( + EXPECT_TRUE(previews_hints()->IsBlacklisted( GURL("https://joe.black.com/path"), PreviewsType::LITE_PAGE_REDIRECT)); EXPECT_FALSE(previews_hints()->IsBlacklisted( GURL("https://nonblack.com"), PreviewsType::LITE_PAGE_REDIRECT)); @@ -337,7 +330,7 @@ TEST_F(PreviewsHintsTest, ParseConfigWithInsufficientConfigDetails) { "Previews.OptimizationFilterStatus.LitePageRedirect", 2 /* FAILED_SERVER_BLACKLIST_BAD_CONFIG */, 1); - EXPECT_FALSE(previews_hints()->IsBlacklisted( + EXPECT_TRUE(previews_hints()->IsBlacklisted( GURL("https://black.com/path"), PreviewsType::LITE_PAGE_REDIRECT)); } @@ -369,7 +362,7 @@ TEST_F(PreviewsHintsTest, ParseConfigWithTooLargeBlacklist) { "Previews.OptimizationFilterStatus.LitePageRedirect", 3 /* FAILED_SERVER_BLACKLIST_TOO_BIG */, 1); - EXPECT_FALSE(previews_hints()->IsBlacklisted( + EXPECT_TRUE(previews_hints()->IsBlacklisted( GURL("https://black.com/path"), PreviewsType::LITE_PAGE_REDIRECT)); } |