diff options
Diffstat (limited to 'chromium/third_party/WebKit/Source/core/inspector/InjectedScriptBase.cpp')
-rw-r--r-- | chromium/third_party/WebKit/Source/core/inspector/InjectedScriptBase.cpp | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/chromium/third_party/WebKit/Source/core/inspector/InjectedScriptBase.cpp b/chromium/third_party/WebKit/Source/core/inspector/InjectedScriptBase.cpp index 574ce40ec6e..af20da9aa9b 100644 --- a/chromium/third_party/WebKit/Source/core/inspector/InjectedScriptBase.cpp +++ b/chromium/third_party/WebKit/Source/core/inspector/InjectedScriptBase.cpp @@ -34,8 +34,8 @@ #include "core/inspector/InjectedScriptBase.h" #include "bindings/v8/ScriptFunctionCall.h" -#include "bindings/v8/ScriptState.h" #include "core/inspector/InspectorInstrumentation.h" +#include "core/inspector/InspectorTraceEvents.h" #include "platform/JSONValues.h" #include "wtf/text/WTFString.h" @@ -49,14 +49,14 @@ InjectedScriptBase::InjectedScriptBase(const String& name) { } -InjectedScriptBase::InjectedScriptBase(const String& name, ScriptObject injectedScriptObject, InspectedStateAccessCheck accessCheck) +InjectedScriptBase::InjectedScriptBase(const String& name, ScriptValue injectedScriptObject, InspectedStateAccessCheck accessCheck) : m_name(name) , m_injectedScriptObject(injectedScriptObject) , m_inspectedStateAccessCheck(accessCheck) { } -void InjectedScriptBase::initialize(ScriptObject injectedScriptObject, InspectedStateAccessCheck accessCheck) +void InjectedScriptBase::initialize(ScriptValue injectedScriptObject, InspectedStateAccessCheck accessCheck) { m_injectedScriptObject = injectedScriptObject; m_inspectedStateAccessCheck = accessCheck; @@ -64,18 +64,23 @@ void InjectedScriptBase::initialize(ScriptObject injectedScriptObject, Inspected bool InjectedScriptBase::canAccessInspectedWindow() const { + ASSERT(!isEmpty()); return m_inspectedStateAccessCheck(m_injectedScriptObject.scriptState()); } -const ScriptObject& InjectedScriptBase::injectedScriptObject() const +const ScriptValue& InjectedScriptBase::injectedScriptObject() const { return m_injectedScriptObject; } ScriptValue InjectedScriptBase::callFunctionWithEvalEnabled(ScriptFunctionCall& function, bool& hadException) const { + ASSERT(!isEmpty()); ExecutionContext* executionContext = m_injectedScriptObject.scriptState()->executionContext(); - InspectorInstrumentationCookie cookie = InspectorInstrumentation::willCallFunction(executionContext, name(), 1); + TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "FunctionCall", "data", InspectorFunctionCallEvent::data(executionContext, 0, name(), 1)); + TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline.stack"), "CallStack", "stack", InspectorCallStackEvent::currentCallStack()); + // FIXME(361045): remove InspectorInstrumentation calls once DevTools Timeline migrates to tracing. + InspectorInstrumentationCookie cookie = InspectorInstrumentation::willCallFunction(executionContext, 0, name(), 1); ScriptState* scriptState = m_injectedScriptObject.scriptState(); bool evalIsDisabled = false; @@ -92,12 +97,13 @@ ScriptValue InjectedScriptBase::callFunctionWithEvalEnabled(ScriptFunctionCall& scriptState->setEvalEnabled(false); InspectorInstrumentation::didCallFunction(cookie); + TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "UpdateCounters", "data", InspectorUpdateCountersEvent::data()); return resultValue; } void InjectedScriptBase::makeCall(ScriptFunctionCall& function, RefPtr<JSONValue>* result) { - if (hasNoValue() || !canAccessInspectedWindow()) { + if (isEmpty() || !canAccessInspectedWindow()) { *result = JSONValue::null(); return; } |