From c551f43206405019121bd2b2c93714319a0a3300 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Thu, 23 Jan 2020 17:21:03 +0100 Subject: BASELINE: Update Chromium to 79.0.3945.139 Change-Id: I336b7182fab9bca80b709682489c07db112eaca5 Reviewed-by: Allan Sandfeld Jensen --- .../resources/settings/about_page/about_page.js | 4 +-- .../about_page/about_page_browser_proxy.js | 29 ++++++---------- .../about_page/channel_switcher_dialog.html | 2 +- .../settings/about_page/detailed_build_info.html | 39 +++++----------------- .../settings/about_page/detailed_build_info.js | 31 ++++++++--------- 5 files changed, 36 insertions(+), 69 deletions(-) (limited to 'chromium/chrome/browser/resources/settings/about_page') diff --git a/chromium/chrome/browser/resources/settings/about_page/about_page.js b/chromium/chrome/browser/resources/settings/about_page/about_page.js index d4781a4d1b7..cdb845116be 100644 --- a/chromium/chrome/browser/resources/settings/about_page/about_page.js +++ b/chromium/chrome/browser/resources/settings/about_page/about_page.js @@ -233,8 +233,8 @@ Polymer({ this.regulatoryInfo_ = info; }); - this.aboutBrowserProxy_.getHasEndOfLife().then(result => { - this.hasEndOfLife_ = result; + this.aboutBrowserProxy_.getEndOfLifeInfo().then(result => { + this.hasEndOfLife_ = !!result.hasEndOfLife; }); this.aboutBrowserProxy_.getEnabledReleaseNotes().then(result => { diff --git a/chromium/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js b/chromium/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js index d1f1373396e..1d5eeb7273d 100644 --- a/chromium/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js +++ b/chromium/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js @@ -27,20 +27,19 @@ let ChannelInfo; /** * @typedef {{ - * arcVersion: string, - * osFirmware: string, - * osVersion: string, + * version: (string|undefined), + * size: (string|undefined), * }} */ -let VersionInfo; +let AboutPageUpdateInfo; /** * @typedef {{ - * version: (string|undefined), - * size: (string|undefined), + * hasEndOfLife: (boolean|undefined), + * eolMessageWithMonthAndYear: (string|undefined), * }} */ -let AboutPageUpdateInfo; +let EndOfLifeInfo; /** * Enumeration of all possible browser channels. @@ -200,18 +199,15 @@ cr.define('settings', function() { /** @return {!Promise} */ getChannelInfo() {} - /** @return {!Promise} */ - getVersionInfo() {} - /** @return {!Promise} */ getRegulatoryInfo() {} /** * Checks if the device has reached end-of-life status and will no longer * receive updates. - * @return {!Promise} + * @return {!Promise} */ - getHasEndOfLife() {} + getEndOfLifeInfo() {} /** * Request TPM firmware update status from the browser. It results in one or @@ -308,19 +304,14 @@ cr.define('settings', function() { return cr.sendWithPromise('getChannelInfo'); } - /** @override */ - getVersionInfo() { - return cr.sendWithPromise('getVersionInfo'); - } - /** @override */ getRegulatoryInfo() { return cr.sendWithPromise('getRegulatoryInfo'); } /** @override */ - getHasEndOfLife() { - return cr.sendWithPromise('getHasEndOfLife'); + getEndOfLifeInfo() { + return cr.sendWithPromise('getEndOfLifeInfo'); } /** @override */ diff --git a/chromium/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html b/chromium/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html index a974334455c..78ac464caad 100644 --- a/chromium/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html +++ b/chromium/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html @@ -19,7 +19,7 @@
$i18n{aboutChangeChannel}
diff --git a/chromium/chrome/browser/resources/settings/about_page/detailed_build_info.html b/chromium/chrome/browser/resources/settings/about_page/detailed_build_info.html index 2369486bc71..fa1ae5f812e 100644 --- a/chromium/chrome/browser/resources/settings/about_page/detailed_build_info.html +++ b/chromium/chrome/browser/resources/settings/about_page/detailed_build_info.html @@ -24,15 +24,6 @@ width: 100%; } -
-
$i18n{aboutPlatformLabel}
-
[[versionInfo_.osVersion]]
-
-
-
$i18n{aboutFirmwareLabel}
-
[[versionInfo_.osFirmware]]
-
$i18n{aboutChannelLabel}
@@ -57,29 +48,17 @@
-
-
$i18n{aboutArcVersionLabel}
-
[[versionInfo_.arcVersion]]
-
-
-
V8
-
$i18n{aboutJsEngineVersion}
-
-
-
$i18n{aboutUserAgentLabel}
-
$i18n{aboutUserAgent}
-
-
-
$i18n{aboutCommandLineLabel}
-
- [[i18n('aboutCommandLine')]] + -
-
$i18n{aboutBuildDateLabel}
-
$i18n{aboutBuildDate}
-
+ + +
diff --git a/chromium/chrome/browser/resources/settings/about_page/detailed_build_info.js b/chromium/chrome/browser/resources/settings/about_page/detailed_build_info.js index 18ad3b217ed..ba47cf969b4 100644 --- a/chromium/chrome/browser/resources/settings/about_page/detailed_build_info.js +++ b/chromium/chrome/browser/resources/settings/about_page/detailed_build_info.js @@ -13,9 +13,6 @@ Polymer({ behaviors: [I18nBehavior], properties: { - /** @private {!VersionInfo} */ - versionInfo_: Object, - /** @private */ currentlyOnChannelText_: String, @@ -24,17 +21,17 @@ Polymer({ /** @private */ canChangeChannel_: Boolean, + + eolMessageWithMonthAndYear: { + type: String, + value: '', + }, }, /** @override */ ready: function() { const browserProxy = settings.AboutPageBrowserProxyImpl.getInstance(); browserProxy.pageReady(); - - browserProxy.getVersionInfo().then(versionInfo => { - this.versionInfo_ = versionInfo; - }); - this.updateChannelInfo_(); }, @@ -50,15 +47,6 @@ Polymer({ }); }, - /** - * @param {string} version - * @return {boolean} - * @private - */ - shouldShowVersion_: function(version) { - return version.length > 0; - }, - /** * @param {boolean} canChangeChannel * @return {string} @@ -93,6 +81,15 @@ Polymer({ this.showChannelSwitcherDialog_ = true; }, + /** + * @param {!Event} e + * @private + */ + onBuildDetailsTap_: function(e) { + e.preventDefault(); + window.open('chrome://version'); + }, + /** @private */ onChannelSwitcherDialogClosed_: function() { this.showChannelSwitcherDialog_ = false; -- cgit v1.2.3