1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
|
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "cc/metrics/compositor_frame_reporting_controller.h"
#include "base/macros.h"
#include "base/test/metrics/histogram_tester.h"
#include "components/viz/common/quads/compositor_frame_metadata.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace cc {
namespace {
class CompositorFrameReportingControllerTest;
class TestCompositorFrameReportingController
: public CompositorFrameReportingController {
public:
TestCompositorFrameReportingController(
CompositorFrameReportingControllerTest* test)
: CompositorFrameReportingController(), test_(test) {}
TestCompositorFrameReportingController(
const TestCompositorFrameReportingController& controller) = delete;
TestCompositorFrameReportingController& operator=(
const TestCompositorFrameReportingController& controller) = delete;
std::unique_ptr<CompositorFrameReporter>* reporters() { return reporters_; }
int ActiveReporters() {
int count = 0;
for (int i = 0; i < PipelineStage::kNumPipelineStages; ++i) {
if (reporters_[i])
++count;
}
return count;
}
protected:
CompositorFrameReportingControllerTest* test_;
};
class CompositorFrameReportingControllerTest : public testing::Test {
public:
CompositorFrameReportingControllerTest() : reporting_controller_(this) {}
// The following functions simulate the actions that would
// occur for each phase of the reporting controller.
void SimulateBeginImplFrame() { reporting_controller_.WillBeginImplFrame(); }
void SimulateBeginMainFrame() {
if (!reporting_controller_.reporters()[CompositorFrameReportingController::
PipelineStage::kBeginImplFrame])
SimulateBeginImplFrame();
CHECK(
reporting_controller_.reporters()[CompositorFrameReportingController::
PipelineStage::kBeginImplFrame]);
reporting_controller_.WillBeginMainFrame();
}
void SimulateCommit() {
if (!reporting_controller_.reporters()[CompositorFrameReportingController::
PipelineStage::kBeginMainFrame])
SimulateBeginMainFrame();
CHECK(
reporting_controller_.reporters()[CompositorFrameReportingController::
PipelineStage::kBeginMainFrame]);
reporting_controller_.WillCommit();
reporting_controller_.DidCommit();
}
void SimulateActivate() {
if (!reporting_controller_.reporters()
[CompositorFrameReportingController::PipelineStage::kCommit])
SimulateCommit();
CHECK(reporting_controller_.reporters()
[CompositorFrameReportingController::PipelineStage::kCommit]);
reporting_controller_.WillActivate();
reporting_controller_.DidActivate();
}
void SimulateSubmitCompositorFrame(uint32_t frame_token) {
if (!reporting_controller_.reporters()
[CompositorFrameReportingController::PipelineStage::kActivate])
SimulateActivate();
CHECK(reporting_controller_.reporters()
[CompositorFrameReportingController::PipelineStage::kActivate]);
reporting_controller_.DidSubmitCompositorFrame(frame_token);
}
void SimulatePresentCompositorFrame() {
++next_token_;
SimulateSubmitCompositorFrame(*next_token_);
reporting_controller_.DidPresentCompositorFrame(*next_token_,
base::TimeTicks::Now());
}
protected:
TestCompositorFrameReportingController reporting_controller_;
private:
viz::FrameTokenGenerator next_token_;
};
TEST_F(CompositorFrameReportingControllerTest, ActiveReporterCounts) {
// Check that there are no leaks with the CompositorFrameReporter
// objects no matter what the sequence of scheduled actions is
// Note that due to DCHECKs in WillCommit(), WillActivate(), etc., it
// is impossible to have 2 reporters both in BMF or Commit
// Tests Cases:
// - 2 Reporters at Activate phase
// - 2 back-to-back BeginImplFrames
// - 4 Simultaneous Reporters
// BF
reporting_controller_.WillBeginImplFrame();
EXPECT_EQ(1, reporting_controller_.ActiveReporters());
// BF -> BF
// Should replace previous reporter.
reporting_controller_.WillBeginImplFrame();
EXPECT_EQ(1, reporting_controller_.ActiveReporters());
// BF -> BMF -> BF
// Should add new reporter.
reporting_controller_.WillBeginMainFrame();
reporting_controller_.WillBeginImplFrame();
EXPECT_EQ(2, reporting_controller_.ActiveReporters());
// BF -> BMF -> BF -> Commit
// Should stay same.
reporting_controller_.WillCommit();
reporting_controller_.DidCommit();
EXPECT_EQ(2, reporting_controller_.ActiveReporters());
// BF -> BMF -> BF -> Commit -> BMF -> Activate -> Commit -> Activation
// Having two reporters at Activate phase should delete the older one.
reporting_controller_.WillBeginMainFrame();
reporting_controller_.WillActivate();
reporting_controller_.DidActivate();
reporting_controller_.WillCommit();
reporting_controller_.DidCommit();
reporting_controller_.WillActivate();
reporting_controller_.DidActivate();
EXPECT_EQ(1, reporting_controller_.ActiveReporters());
reporting_controller_.DidSubmitCompositorFrame(0);
EXPECT_EQ(0, reporting_controller_.ActiveReporters());
// 4 simultaneous reporters active.
SimulateActivate();
SimulateCommit();
SimulateBeginMainFrame();
SimulateBeginImplFrame();
EXPECT_EQ(4, reporting_controller_.ActiveReporters());
// Any additional BeginImplFrame's would be ignored.
SimulateBeginImplFrame();
EXPECT_EQ(4, reporting_controller_.ActiveReporters());
}
TEST_F(CompositorFrameReportingControllerTest,
SubmittedFrameHistogramReporting) {
base::HistogramTester histogram_tester;
// 2 reporters active.
SimulateActivate();
SimulateBeginImplFrame();
// Submitting and Presenting the next reporter should be a missed.
SimulatePresentCompositorFrame();
histogram_tester.ExpectTotalCount(
"CompositorLatency.MissedFrame.BeginImplFrameToSendBeginMainFrame", 1);
histogram_tester.ExpectTotalCount(
"CompositorLatency.MissedFrame.SendBeginMainFrameToCommit", 1);
histogram_tester.ExpectTotalCount("CompositorLatency.MissedFrame.Commit", 1);
histogram_tester.ExpectTotalCount(
"CompositorLatency.MissedFrame.EndCommitToActivation", 1);
histogram_tester.ExpectTotalCount("CompositorLatency.MissedFrame.Activation",
1);
histogram_tester.ExpectTotalCount(
"CompositorLatency.MissedFrame.EndActivateToSubmitCompositorFrame", 1);
// Other histograms should not be reported.
histogram_tester.ExpectTotalCount(
"CompositorLatency.BeginImplFrameToSendBeginMainFrame", 0);
histogram_tester.ExpectTotalCount(
"CompositorLatency.SendBeginMainFrameToCommit", 0);
histogram_tester.ExpectTotalCount("CompositorLatency.Commit", 0);
histogram_tester.ExpectTotalCount("CompositorLatency.EndCommitToActivation",
0);
histogram_tester.ExpectTotalCount("CompositorLatency.Activation", 0);
histogram_tester.ExpectTotalCount(
"CompositorLatency.EndActivateToSubmitCompositorFrame", 0);
// Submitting the next reporter will not be counted as missed.
// In practice this submitted frame should be considered as missed because a
// new BeginFrame would have been issued, which is the cause for this frame
// submission.
SimulatePresentCompositorFrame();
// Other histograms should not be reported.
histogram_tester.ExpectTotalCount(
"CompositorLatency.BeginImplFrameToSendBeginMainFrame", 1);
histogram_tester.ExpectTotalCount(
"CompositorLatency.SendBeginMainFrameToCommit", 1);
histogram_tester.ExpectTotalCount("CompositorLatency.Commit", 1);
histogram_tester.ExpectTotalCount("CompositorLatency.EndCommitToActivation",
1);
histogram_tester.ExpectTotalCount("CompositorLatency.Activation", 1);
histogram_tester.ExpectTotalCount(
"CompositorLatency.EndActivateToSubmitCompositorFrame", 1);
// Missed frame histogram counts should not change.
histogram_tester.ExpectTotalCount(
"CompositorLatency.MissedFrame.BeginImplFrameToSendBeginMainFrame", 1);
histogram_tester.ExpectTotalCount(
"CompositorLatency.MissedFrame.SendBeginMainFrameToCommit", 1);
histogram_tester.ExpectTotalCount("CompositorLatency.MissedFrame.Commit", 1);
histogram_tester.ExpectTotalCount(
"CompositorLatency.MissedFrame.EndCommitToActivation", 1);
histogram_tester.ExpectTotalCount("CompositorLatency.MissedFrame.Activation",
1);
histogram_tester.ExpectTotalCount(
"CompositorLatency.MissedFrame.EndActivateToSubmitCompositorFrame", 1);
}
} // namespace
} // namespace cc
|
