blob: b5099b06a0945d3c182d333906aeabca77d5943a (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
|
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/test/base/testing_profile.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "extensions/browser/api_test_utils.h"
namespace extensions {
class BookmarkManagerPrivateApiUnitTest : public ExtensionServiceTestBase {
public:
BookmarkManagerPrivateApiUnitTest() {}
void SetUp() override {
ExtensionServiceTestBase::SetUp();
InitializeEmptyExtensionService();
profile_->CreateBookmarkModel(false);
model_ = BookmarkModelFactory::GetForBrowserContext(profile());
bookmarks::test::WaitForBookmarkModelToLoad(model_);
const bookmarks::BookmarkNode* node =
model_->AddURL(model_->other_node(), 0, base::ASCIIToUTF16("Goog"),
GURL("https://www.google.com"));
// Store node->id() as we will delete |node| in RunOnDeletedNode().
node_id_ = base::NumberToString(node->id());
}
std::string node_id() const { return node_id_; }
private:
bookmarks::BookmarkModel* model_ = nullptr;
std::string node_id_;
DISALLOW_COPY_AND_ASSIGN(BookmarkManagerPrivateApiUnitTest);
};
// Tests that running ExtensionFunction-s on deleted bookmark node gracefully
// fails.
// Regression test for https://crbug.com/739260.
TEST_F(BookmarkManagerPrivateApiUnitTest, RunOnDeletedNode) {
// Remove our only bookmark node.
scoped_refptr<BookmarksRemoveFunction> remove_function(
new BookmarksRemoveFunction());
api_test_utils::RunFunction(remove_function.get(),
base::StringPrintf("[\"%s\"]", node_id().c_str()),
profile());
// Call bookmarkManagerPrivate.copy() with the removed bookmark node's id.
scoped_refptr<BookmarkManagerPrivateCopyFunction> copy_function(
new BookmarkManagerPrivateCopyFunction());
EXPECT_EQ(
"Could not find bookmark nodes with given ids.",
api_test_utils::RunFunctionAndReturnError(
copy_function.get(),
base::StringPrintf("[[\"%s\"]]", node_id().c_str()), profile()));
}
} // namespace extensions
|
