summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexandru Croitor <alexandru.croitor@theqtcompany.com>2016-04-26 16:39:20 +0200
committerAlexandru Croitor <alexandru.croitor@theqtcompany.com>2016-04-27 13:11:35 +0000
commitfe84829aeb3ba19b74935198dbcbd6f5c67915b3 (patch)
treeb7e7065e79d0d00f29e04c41cf1fef643d063fa6
parent55f4e7c382093227aa8d43d396a5b216d732e655 (diff)
Fix unexpected passes in tst_QWebEnginePage::setHtmlWithImageResource.
Requesting a local file resource without a baseUrl set, should not be allowed. This hasn't worked before in Webkit, so the checks were marked with QEXPECT_FAIL. Remove these, as the issue has been fixed, and now causes unexpected passes. Change-Id: I7d38692a9961651d48abe28218d7ee022a85f101 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
-rw-r--r--tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp b/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp
index 715050fcc..5d53c0468 100644
--- a/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp
+++ b/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp
@@ -3980,9 +3980,7 @@ void tst_QWebEnginePage::setHtmlWithImageResource()
page.setHtml(html);
waitForSignal(&page, SIGNAL(loadFinished(bool)));
QCOMPARE(evaluateJavaScriptSync(&page, "document.images.length").toInt(), 1);
- QEXPECT_FAIL("", "https://bugs.webkit.org/show_bug.cgi?id=118659", Continue);
QCOMPARE(evaluateJavaScriptSync(&page, "document.images[0].width").toInt(), 0);
- QEXPECT_FAIL("", "https://bugs.webkit.org/show_bug.cgi?id=118659", Continue);
QCOMPARE(evaluateJavaScriptSync(&page, "document.images[0].height").toInt(), 0);
}