diff options
| author | Kirill Burtsev <kirill.burtsev@qt.io> | 2021-08-05 15:11:57 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-09-12 14:33:15 +0000 |
| commit | 78898d5adb833e90e8435c728ec0ff339d2cd5a6 (patch) | |
| tree | ed9af433d10d01fd87fc2b66e95792ac3fb4f52a | |
| parent | 9d6fe8a1e37d16f4df036d2cde906355716cfaed (diff) | |
Remove check for profile directory from favicon service factory
Since the directory itself in initialized asynchronously this check
may lead to desynchronization with how profile is considered to be off
the record and what it really is. Subsequently, with a possible wrong
initialization of a favicon service with invalid history service for
non-otr profile.
Fixes: QTBUG-95580
Change-Id: I66fbb7914a303650490e1577989beee5cd883037
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 498c4ac362cb6cbee8a30c8cc46fa4253bf93ee0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | src/core/favicon_service_factory_qt.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/core/favicon_service_factory_qt.cpp b/src/core/favicon_service_factory_qt.cpp index 898882486..6810927c9 100644 --- a/src/core/favicon_service_factory_qt.cpp +++ b/src/core/favicon_service_factory_qt.cpp @@ -84,8 +84,6 @@ HistoryServiceFactoryQt::GetForBrowserContext(content::BrowserContext *context) if (context->IsOffTheRecord()) return nullptr; - if (!base::PathExists(context->GetPath())) - return nullptr; return static_cast<history::HistoryService *>( GetInstance()->GetServiceForBrowserContext(context, true)); @@ -115,7 +113,6 @@ KeyedService * HistoryServiceFactoryQt::BuildServiceInstanceFor(content::BrowserContext *context) const { Q_ASSERT(!context->IsOffTheRecord()); - Q_ASSERT(base::PathExists(context->GetPath())); std::unique_ptr<history::HistoryService> historyService( new history::HistoryService(std::make_unique<HistoryClientQt>(), nullptr)); |