diff options
| author | Allan Sandfeld Jensen <allan.jensen@theqtcompany.com> | 2016-05-12 14:35:34 +0200 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2016-05-13 12:00:22 +0000 |
| commit | d1d64e6e66f53ccd4eb0a548e9ce726190ebae91 (patch) | |
| tree | 19c25199910927ccb6535bf1be60b67e4d0ce02d /src/core/url_request_custom_job.h | |
| parent | 0f721b93f908828952b17f2f71a66c938f680fb1 (diff) | |
Better handle failure on read in custom url handlers
Chromium 49 expects url request failures to be reported as a response
to either start or on read. So we should report failures during read
and make sure we can handle QIODevice calling fail on the job.
Change-Id: Id8f619d3cb6f187c99da580c6923130a95ca91ee
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
Diffstat (limited to 'src/core/url_request_custom_job.h')
| -rw-r--r-- | src/core/url_request_custom_job.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/url_request_custom_job.h b/src/core/url_request_custom_job.h index 226c39e68..3fce76d36 100644 --- a/src/core/url_request_custom_job.h +++ b/src/core/url_request_custom_job.h @@ -61,7 +61,7 @@ public: URLRequestCustomJob(net::URLRequest *request, net::NetworkDelegate *networkDelegate, const std::string &scheme, QWeakPointer<const BrowserContextAdapter> adapter); virtual void Start() Q_DECL_OVERRIDE; virtual void Kill() Q_DECL_OVERRIDE; - virtual int ReadRawData(net::IOBuffer* buf, int buf_size) Q_DECL_OVERRIDE;; + virtual int ReadRawData(net::IOBuffer *buf, int buf_size) Q_DECL_OVERRIDE; virtual bool GetMimeType(std::string *mimeType) const Q_DECL_OVERRIDE; virtual bool GetCharset(std::string *charset) Q_DECL_OVERRIDE; virtual bool IsRedirectResponse(GURL* location, int* http_status_code) Q_DECL_OVERRIDE; |