diff options
author | Jocelyn Turcotte <jocelyn.turcotte@digia.com> | 2014-04-07 14:00:35 +0200 |
---|---|---|
committer | The Qt Project <gerrit-noreply@qt-project.org> | 2014-04-15 17:03:28 +0200 |
commit | 84ced937a0f9f2874e32e16c4c6ebf72b46904c9 (patch) | |
tree | d78373210638476d0e0ee67e398dca7a1630544b /src/core | |
parent | fc55f57e6cbbcd0027493d0bbea8161a814aaff2 (diff) |
Replace uses of QWebEngineFrame with a security origin URL
This changes implemented methods. The rest of the references will go
away with the public headers cleanup.
Change-Id: I82340cd7a4488c4b463489ae98cd9c16de4e7487
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
Diffstat (limited to 'src/core')
-rw-r--r-- | src/core/javascript_dialog_controller.cpp | 9 | ||||
-rw-r--r-- | src/core/javascript_dialog_controller.h | 1 | ||||
-rw-r--r-- | src/core/javascript_dialog_controller_p.h | 4 | ||||
-rw-r--r-- | src/core/javascript_dialog_manager_qt.cpp | 3 |
4 files changed, 13 insertions, 4 deletions
diff --git a/src/core/javascript_dialog_controller.cpp b/src/core/javascript_dialog_controller.cpp index ed0431084..973fa89b7 100644 --- a/src/core/javascript_dialog_controller.cpp +++ b/src/core/javascript_dialog_controller.cpp @@ -54,10 +54,12 @@ void JavaScriptDialogControllerPrivate::dialogFinished(bool accepted, const base } JavaScriptDialogControllerPrivate::JavaScriptDialogControllerPrivate(WebContentsAdapterClient::JavascriptDialogType t, const QString &msg, const QString &prompt - , const content::JavaScriptDialogManager::DialogClosedCallback &cb, content::WebContents *c) + , const QUrl &securityOrigin, const content::JavaScriptDialogManager::DialogClosedCallback &cb + , content::WebContents *c) : type(t) , message(msg) , defaultPrompt(prompt) + , securityOrigin(securityOrigin) , callback(cb) , contents(c) { @@ -82,6 +84,11 @@ WebContentsAdapterClient::JavascriptDialogType JavaScriptDialogController::type( return d->type; } +QUrl JavaScriptDialogController::securityOrigin() const +{ + return d->securityOrigin; +} + void JavaScriptDialogController::textProvided(const QString &text) { d->userInput = text; diff --git a/src/core/javascript_dialog_controller.h b/src/core/javascript_dialog_controller.h index b0d598afa..755a2712b 100644 --- a/src/core/javascript_dialog_controller.h +++ b/src/core/javascript_dialog_controller.h @@ -55,6 +55,7 @@ public: QString message() const; QString defaultPrompt() const; WebContentsAdapterClient::JavascriptDialogType type() const; + QUrl securityOrigin() const; public Q_SLOTS: void textProvided(const QString &text); diff --git a/src/core/javascript_dialog_controller_p.h b/src/core/javascript_dialog_controller_p.h index 9e84b31a0..0d7552ce2 100644 --- a/src/core/javascript_dialog_controller_p.h +++ b/src/core/javascript_dialog_controller_p.h @@ -55,11 +55,13 @@ class JavaScriptDialogControllerPrivate { public: void dialogFinished(bool accepted, const base::string16 &promptValue); JavaScriptDialogControllerPrivate(WebContentsAdapterClient::JavascriptDialogType, const QString &message, const QString &prompt - , const content::JavaScriptDialogManager::DialogClosedCallback &, content::WebContents *); + , const QUrl &securityOrigin, const content::JavaScriptDialogManager::DialogClosedCallback & + , content::WebContents *); WebContentsAdapterClient::JavascriptDialogType type; QString message; QString defaultPrompt; + QUrl securityOrigin; QString userInput; content::JavaScriptDialogManager::DialogClosedCallback callback; content::WebContents *contents; diff --git a/src/core/javascript_dialog_manager_qt.cpp b/src/core/javascript_dialog_manager_qt.cpp index 1cde76a8f..1e37481b6 100644 --- a/src/core/javascript_dialog_manager_qt.cpp +++ b/src/core/javascript_dialog_manager_qt.cpp @@ -58,7 +58,6 @@ JavaScriptDialogManagerQt *JavaScriptDialogManagerQt::GetInstance() void JavaScriptDialogManagerQt::RunJavaScriptDialog(content::WebContents *webContents, const GURL &originUrl, const std::string &acceptLang, content::JavaScriptMessageType javascriptMessageType, const base::string16 &messageText, const base::string16 &defaultPromptText, const content::JavaScriptDialogManager::DialogClosedCallback &callback, bool *didSuppressMessage) { - Q_UNUSED(originUrl); Q_UNUSED(acceptLang); WebContentsAdapterClient *client = WebContentsViewQt::from(webContents->GetView())->client(); @@ -69,7 +68,7 @@ void JavaScriptDialogManagerQt::RunJavaScriptDialog(content::WebContents *webCon WebContentsAdapterClient::JavascriptDialogType dialogType = static_cast<WebContentsAdapterClient::JavascriptDialogType>(javascriptMessageType); JavaScriptDialogControllerPrivate *dialogData = new JavaScriptDialogControllerPrivate(dialogType, toQt(messageText).toHtmlEscaped() - , toQt(defaultPromptText).toHtmlEscaped(), callback, webContents); + , toQt(defaultPromptText).toHtmlEscaped(), toQt(originUrl), callback, webContents); QSharedPointer<JavaScriptDialogController> dialog(new JavaScriptDialogController(dialogData)); // We shouldn't get new dialogs for a given WebContents until we gave back a result. |