diff options
| author | Jüri Valdmann <juri.valdmann@qt.io> | 2020-04-03 12:33:33 +0200 |
|---|---|---|
| committer | Jüri Valdmann <juri.valdmann@qt.io> | 2020-04-09 08:37:03 +0200 |
| commit | 9edaf3675cb8e94372bff579cbaec022ca26ee21 (patch) | |
| tree | f166bd10231060adbdca27489fb65d4d980ca352 /src/core | |
| parent | cee8776777e72f2820f04f1df00e2aeebbf9af49 (diff) | |
Use SetBaseBackgroundColorOverride for setting background color
The normal WebViewImpl::SetBaseBackgroundColor expects to be called only during
certain lifecycle states, otherwise a DCHECK will be triggered. Whereas
the *Override version forces a lifecycle update.
Needs 3rdparty change to stop RenderWidgetHostViewBase::SetBaseBackgroundColor
from clearing the override color when switching between opaque and transparent
colors though.
Change-Id: If4c1e22886d7ebc7d87ca880dd9c6a659855a931
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Diffstat (limited to 'src/core')
| -rw-r--r-- | src/core/renderer/render_view_observer_qt.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/renderer/render_view_observer_qt.cpp b/src/core/renderer/render_view_observer_qt.cpp index 731d8b97d..5b0b9a77d 100644 --- a/src/core/renderer/render_view_observer_qt.cpp +++ b/src/core/renderer/render_view_observer_qt.cpp @@ -73,7 +73,7 @@ void RenderViewObserverQt::onFetchDocumentInnerText(quint64 requestId) void RenderViewObserverQt::onSetBackgroundColor(quint32 color) { - render_view()->GetWebView()->SetBaseBackgroundColor(color); + render_view()->GetWebView()->SetBaseBackgroundColorOverride(color); } void RenderViewObserverQt::OnDestruct() |