Improve Q(Quick)WebEngineDownloadItem API

Implements suggestions from 5.14 API review:
- Replace QString with const QString &
- Extend documentation

Change-Id: I08365767128aa72bc7ef2356c761c2abe512e4eb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

2 files changed, 10 insertions, 7 deletions

diff --git a/src/webengine/api/qquickwebenginedownloaditem.cpp b/src/webengine/api/qquickwebenginedownloaditem.cpp
index 3ccd27094..878dddadb 100644
--- a/src/webengine/api/qquickwebenginedownloaditem.cpp
+++ b/src/webengine/api/qquickwebenginedownloaditem.cpp
@@ -420,6 +420,9 @@ QString QQuickWebEngineDownloadItem::mimeType() const
     \qmlproperty string WebEngineDownloadItem::path
     \obsolete
 
+    Use \l suggestedFileName, \l downloadDirectory, and
+    \l downloadFileName instead.
+
     Holds the full target path where data is being downloaded to.
 
     The path includes the file name. The default suggested path is the standard
@@ -500,7 +503,7 @@ QString QQuickWebEngineDownloadItem::downloadDirectory() const
     return d->downloadDirectory;
 }
 
-void QQuickWebEngineDownloadItem::setDownloadDirectory(QString directory)
+void QQuickWebEngineDownloadItem::setDownloadDirectory(const QString &directory)
 {
     Q_D(QQuickWebEngineDownloadItem);
     if (d->downloadState != QQuickWebEngineDownloadItem::DownloadRequested) {
@@ -548,7 +551,7 @@ QString QQuickWebEngineDownloadItem::downloadFileName() const
     return d->downloadFileName;
 }
 
-void QQuickWebEngineDownloadItem::setDownloadFileName(QString fileName)
+void QQuickWebEngineDownloadItem::setDownloadFileName(const QString &fileName)
 {
     Q_D(QQuickWebEngineDownloadItem);
     if (d->downloadState != QQuickWebEngineDownloadItem::DownloadRequested) {
diff --git a/src/webengine/api/qquickwebenginedownloaditem_p.h b/src/webengine/api/qquickwebenginedownloaditem_p.h
index cef99e534..96ef0daf0 100644
--- a/src/webengine/api/qquickwebenginedownloaditem_p.h
+++ b/src/webengine/api/qquickwebenginedownloaditem_p.h
@@ -152,8 +152,8 @@ public:
     qint64 totalBytes() const;
     qint64 receivedBytes() const;
     QString mimeType() const;
-    QString Q_DECL_DEPRECATED path() const;
-    void Q_DECL_DEPRECATED setPath(QString path);
+    QString path() const;
+    void setPath(QString path);
     SavePageFormat savePageFormat() const;
     void setSavePageFormat(SavePageFormat format);
     DownloadType Q_DECL_DEPRECATED type() const;
@@ -166,9 +166,9 @@ public:
     QUrl url() const;
     QString suggestedFileName() const;
     QString downloadDirectory() const;
-    void setDownloadDirectory(QString directory);
+    void setDownloadDirectory(const QString &directory);
     QString downloadFileName() const;
-    void setDownloadFileName(QString fileName);
+    void setDownloadFileName(const QString &fileName);
 
 Q_SIGNALS:
     void stateChanged();
@@ -176,7 +176,7 @@ Q_SIGNALS:
     void receivedBytesChanged();
     void totalBytesChanged();
     Q_REVISION(1) void mimeTypeChanged();
-    void Q_DECL_DEPRECATED pathChanged();
+    void pathChanged();
     Q_REVISION(3) void typeChanged();
     Q_REVISION(4) void interruptReasonChanged();
     Q_REVISION(5) void isFinishedChanged();