diff options
| author | Jocelyn Turcotte <jocelyn.turcotte@digia.com> | 2014-03-21 17:34:21 +0100 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2014-03-24 16:05:43 +0100 |
| commit | 75aa1821d151f2103abece4942624104426e0c17 (patch) | |
| tree | bdaae9e529eb5b45188e82ff47a3629b41f7ab74 /tests/auto/widgets | |
| parent | f06cb10ce5a6d543d97bd05484179f56b60e6e5a (diff) | |
Fix a missing titleChanged signal on navigation
WebContentsView::SetPageTitle is only called when the Blink page
updated its title. For navigations we have to listen for
NavigationStateChanged.
Also update the history test to check this case.
Change-Id: Ia89c61b32913d647a63b2fb9a4cdf3f6867c4f0c
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
Diffstat (limited to 'tests/auto/widgets')
| -rw-r--r-- | tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp b/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp index 2b5f4101c..f2b11c5c2 100644 --- a/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp +++ b/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp @@ -124,10 +124,13 @@ void tst_QWebEngineHistory::count() */ void tst_QWebEngineHistory::back() { + SignalBarrier titleChangedBarrier(page, SIGNAL(titleChanged(const QString&))); + for (int i = histsize;i > 1;i--) { QCOMPARE(toPlainTextSync(page), QString("page") + QString::number(i)); hist->back(); loadFinishedBarrier->ensureSignalEmitted(); + QVERIFY(titleChangedBarrier.ensureSignalEmitted()); } //try one more time (too many). crash test hist->back(); @@ -145,10 +148,12 @@ void tst_QWebEngineHistory::forward() loadFinishedBarrier->ensureSignalEmitted(); } + SignalBarrier titleChangedBarrier(page, SIGNAL(titleChanged(const QString&))); for (int i = 1;i < histsize;i++) { QCOMPARE(toPlainTextSync(page), QString("page") + QString::number(i)); hist->forward(); loadFinishedBarrier->ensureSignalEmitted(); + QVERIFY(titleChangedBarrier.ensureSignalEmitted()); } //try one more time (too many). crash test hist->forward(); |