summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorPierre Rossi <pierre.rossi@digia.com>2014-10-01 12:43:50 +0200
committerPierre Rossi <pierre.rossi@gmail.com>2014-10-13 14:49:48 +0200
commit85523c788569f9276f102aadb1f6a7d0c043111c (patch)
tree9c5e7f813cc2b0a256e88e11955b8c18d1d986b2 /tests
parentd69e0bb0d2fade75c31e57047c03746d694a6113 (diff)
TestBrowser: prevent popups from getting GCed
This is a quick fix that only works because dialogs shouldn't outlive the page that opened them. We still have a problem for the new window case. Change-Id: I652e545f7eac394a915f7f173795dc0f187fc6ea Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
Diffstat (limited to 'tests')
-rw-r--r--tests/quicktestbrowser/quickwindow.qml2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/quicktestbrowser/quickwindow.qml b/tests/quicktestbrowser/quickwindow.qml
index ebde5b1ab..36668fc6d 100644
--- a/tests/quicktestbrowser/quickwindow.qml
+++ b/tests/quicktestbrowser/quickwindow.qml
@@ -346,7 +346,7 @@ ApplicationWindow {
var tab = tabs.createEmptyTab()
request.openIn(tab.item.webView)
} else if (request.destination == WebEngineView.NewViewInDialog) {
- var dialog = dialogComponent.createObject()
+ var dialog = dialogComponent.createObject(webEngineView)
request.openIn(dialog.webView)
} else {
var component = Qt.createComponent("quickwindow.qml")