Fix how NewPopupDisposition is exposed in QQuickWebEngineView

I initially misintepreted the meaning of the enum, assuming that it
meant that the window should possibly be blocked. The user_gesture
parameter in WebContentsDelegate::AddNewContents is actually doing
this, while the popup disposition means that JavaScript requested
the window to be opened without one of the standard decoration (i.e.
status bar, menu bar, tool bar, etc.).

Update the QtQuick API to reflect this, renaming the "isPopup"
parameter to a more familiar "isUserInitiated".

The popup disposition is named "dialog" to match the previous
QWebPage::WebModalDialog enum.

Change-Id: Ib0c4bc53671fcf0dd9499aa1be2bbc8c494ba49e
Reviewed-by: Michael Bruning <michael.bruning@digia.com>

1 files changed, 18 insertions, 1 deletions

diff --git a/tests/quicktestbrowser/quickwindow.qml b/tests/quicktestbrowser/quickwindow.qml
index 891ab5792..f77fec582 100644
--- a/tests/quicktestbrowser/quickwindow.qml
+++ b/tests/quicktestbrowser/quickwindow.qml
@@ -235,6 +235,20 @@ ApplicationWindow {
         Component.onCompleted: createEmptyTab()
 
         Component {
+            id: dialogComponent
+            Window {
+                property Item webView: _webView
+                width: 800
+                height: 600
+                visible: true
+                WebEngineView {
+                    id: _webView
+                    anchors.fill: parent
+                }
+            }
+        }
+
+        Component {
             id: tabComponent
             WebEngineView {
                 id: webEngineView
@@ -268,11 +282,14 @@ ApplicationWindow {
                     }
 
                     onNewViewRequested: {
-                        if (request.popup)
+                        if (!request.userInitiated)
                             print("Warning: Blocked a popup window.")
                         else if (request.destination == WebEngineView.NewViewInTab) {
                             var tab = tabs.createEmptyTab()
                             request.openIn(tab.item)
+                        } else if (request.destination == WebEngineView.NewViewInDialog) {
+                            var dialog = dialogComponent.createObject()
+                            request.openIn(dialog.webView)
                         } else {
                             var component = Qt.createComponent("quickwindow.qml")
                             var window = component.createObject()