summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Fix -no-ssl buildv5.13.0-beta1Peter Varga2019-03-076-0/+30
| | | | | Change-Id: I978f70545484060218f5243c74978c85bc603c16 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge remote-tracking branch 'origin/5.12' into 5.13Allan Sandfeld Jensen2019-03-0438-170/+407
|\ | | | | | | Change-Id: I1dd136df7004b11e2f38a2ec4e82a6fa81627479
| * Force destruction of webcontent client before profile adapterMichal Klocek2019-03-0112-19/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently users might forget to delete webcontent client before profile adapter. This might be nasty if users are not aware of default profile. Instead of asserting badly in chromium, clean up and release chromium resources. This avoids the crash, but might leak memory if users never deletes page. Task-number: QTBUG-74021 Change-Id: I66f466f169d12f7ee08866d505260dca47800bb0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix destruction of qt quick profile after WebEngineContext gets deletedMichal Klocek2019-03-011-1/+2
| | | | | | | | | | | | | | | | | | | | Issue takes place when QQmlApplicationEngine is a child of qApp. In case WebEngineContext gets destructed do not try to get default profile, which is anyway already gone. Task-number: QTBUG-74116 Change-Id: I24ea87baf677360a420d444b4c964feb722ab317 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix incrementing download IDTamas Zakor2019-02-282-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | Adapt DownloadManagerDelegateQt::m_currentId to https://chromium-review.googlesource.com/1144311 Update Chromium: 09516a434b [Backport] Allow DownloadManagerImpl to get InProgressDownloadManager from DownloadManagerService b3edbf2a84 [Backport] Make DownloadManagerImpl to generate download IDs for in-progress DB Task-number: QTBUG-70702 Change-Id: I1224643398a2084fcd5d70d2c04b105ed69c1f3d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Merge "Merge remote-tracking branch 'origin/5.12.2' into 5.12" into ↵Allan Sandfeld Jensen2019-02-271-0/+0
| |\ | | | | | | | | | refs/staging/5.12
| | * Merge remote-tracking branch 'origin/5.12.2' into 5.12Allan Sandfeld Jensen2019-02-271-0/+0
| | |\ | | | | | | | | | | | | Change-Id: I423ab09061b0fb1963953438e6e6b09b2602254f
| | | * Update ChromiumAllan Sandfeld Jensen2019-02-201-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The last of the security fixes from Chrome 72 Changes: 493fab1afff5 [Backport] Fix for security issue 895970 Fixes: QTBUG-73417 Change-Id: If6a4f6f5773c99db3498e3b178cce39e36c85e79 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | | * Merge 5.12 into 5.12.2Kari Oikarinen2019-02-2011-37/+93
| | | |\ | | | | | | | | | | | | | | | Change-Id: I660e890b4630fba2c6828571cac99a529f24be50
| | | * | Update ChromiumAllan Sandfeld Jensen2019-02-151-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: 61b45663dff1 [Backport] Fix for security issue 903500 a3b4be8d0247 [Backport] Fix security issue 901677 82b53e95166e [Backport] Fix security issue 895117 a26c352168ec [Backport] Fix for CVE-2019-5784 Task-number: QTBUG-73417 Change-Id: I149ae5a5cd4d83f17bd0c603dd2e3a1079c86e82 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * | | | Doc: Fix JavaScriptDialogRequest.DialogTypeBeforeUnload enum valueLeena Miettinen2019-02-271-3/+3
| |/ / / | | | | | | | | | | | | | | | | | | | | Fixes: QTBUG-74070 Change-Id: Iad514671a588c0a3e0405dd0141ef54320ae8c86 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| * | | Fix crash on dynamic_cast in global event filterJüri Valdmann2019-02-256-66/+175
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Installing an event filter on QApplication which uses dynamic_cast will crash the application since QtWebEngine is sending QTimerEvents to classes without RTTI information. Fix by 1. Moving the QObject part of MessagePumpForUIQt into api/ as a private class. 2. Using QTimer directly in WebEngineSettings, without subclassing. Fixes: QTBUG-73833 Change-Id: Ida73006a4fef76637c964f8f05468adcc4a190ce Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | | Fix handling of touch icons when it is disabledPeter Varga2019-02-253-14/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Store the icon type in a bitfield because the same icon URL might be used for various types on same page. This way webengine won't ignore to download a default icon what is also set as a touch icon when touch icons are disabled. Moreover, do not store the icon types from the previous page because a subsequent page might use the same icon URL but with different type. With this change the type of the cached icons are updated after each page load. Fixes: QTBUG-70081 Change-Id: I8031a740b07b0c6a8e5759a994f386b13ce87be2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | | Doc: Always treat \brief as full sentenceKai Koehne2019-02-2211-27/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure all \brief descriptions start with an upper-case letter and end with a . Also start descriptions of \class with the name of the class or struct. Change-Id: Ifd2656201f9c1dff092085508a5423ce516e2d3f Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
| * | | Clarify documentation of QWebEnginePage::title()Jüri Valdmann2019-02-222-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explain what happens when the HTML has no proper <title> defined and clarify the meaning of 'by default': it refers to the state before load()/setUrl()/etc. Fixes: QTBUG-71799 Change-Id: Ib2669007573b3ea53e205d9228237bae392f6f78 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
| * | | Doc: Copy minimal example code into overview pageKai Koehne2019-02-211-3/+13
| | |/ | |/| | | | | | | | | | | | | | | | | | | After change cfe53bce9, the 'minimal' example isn't that minimal anymore. Rather copy the few lines, like we already do for the widget example. Change-Id: I9dd818738edb8d229f54ff24822d4c1723376ccc Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
| * | Remove download properly on profile destruction to avoid use after freeKirill Burtsev2019-02-196-25/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the Widgets API, download items are children of the profile and are destroyed when the parent profile destroys its children. The download item's destructor can therefore not access the profile, as it would cause a heap-use-after-free crashes. On quick side turn ongoing downloads cleanup to match widgets one. Fixes: QTBUG-73839 Change-Id: Iabb379e91187e3e68ebcd4693fec35883b72b1f2 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| * | Set download state to finished when cancelling or destroying the download itemKirill Burtsev2019-02-194-10/+34
| | | | | | | | | | | | | | | | | | | | | Task-number: QTBUG-73839 Change-Id: Ieebaa802bdfe0c410618e4213a9bedbbae9d0f61 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| * | Doc: Fix type of WebEngineDownloadItem::view propertyKirill Burtsev2019-02-191-1/+3
| | | | | | | | | | | | | | | | | | Change-Id: I46fc228d99ad6d89d6f2a79a7f3c3352befe0a64 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| * | Fix crash in tst_Spellchecking::spellcheckJüri Valdmann2019-02-193-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test tst_Spellchecking::spellcheck crashes when run with QT_LOGGING_RULES=qt.accessibility.cache.debug=true which triggers debug output from QAccessible::registerAccessibleInterface and QAccessible::deleteAccessibleInterface These functions are called during the construction/destruction of BrowserAccessibilityQt. The problem is that BrowserAccessibilityQt is not necessarily in a valid state at these times: BrowserAccessibilityQt relies on it's manager to be *fully* initialized yet BrowserAccessibilityQt may be constructed/destructed *during* the managers construction/destruction. The solution is to override QAccessibleInterface::isValid to return true only if the manager is in a valid state too. This disables the debug output and avoids the crash. Fixes: QTBUG-72878 Change-Id: Icffe4e503145133c24535fb094bbcb606568e57c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | | Tie client certificate stores to profilesAllan Sandfeld Jensen2019-03-0112-37/+75
| | | | | | | | | | | | | | | | | | | | | | | | Move the client certificate store from being global to being tied to individual profiles. Change-Id: Ib21ae14c501b7d0612b84ae7535120291aeeada2 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Pass the path to the macOS SDK used by Qt to the gn build scriptMichael Brüning2019-03-012-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Uses the value in QMAKE_MAC_SDK_PATH that Qt also uses as an isysroot parameter. Updates Chromium: 3fe203d43c Soften check for single thread only if layer1 or layer2 sandbox 0aae24c287 Add isysroot parameter for macOS to build gn with the right toolchain Change-Id: I0315a054e066ec5743235347d7e96ac8b2c05c3b Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | | Fix detection of opengl supportMichal Klocek2019-02-271-20/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up tryGL check and add missing check for platform capability so webengine tests can run on arm in ci. Note this change only fixes webengine with offscreen plugin wihtout xlib support, which is the case for coin ci. Task-number: QTBUG-63346 Change-Id: I66fe6457f98815dad0dcd02df4500dc0ff752958 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Cleanup QML client certificate selection implementationAllan Sandfeld Jensen2019-02-273-23/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | Get rid of copy constructors for QObjects by making the elements objects on the heap. Change-Id: Ic9a214f01b39feb824b99d17d17fd342d431cd97 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | API cleanupAllan Sandfeld Jensen2019-02-276-22/+13
| | | | | | | | | | | | | | | | | | | | | Based on review feedback Change-Id: Ide40d4fd563ea682eaa2cc457d857445adea85cd Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Doc: Rename 'Notificatons' section to 'Web Notifications'Kai Koehne2019-02-272-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | This is more descriptive / easier to search for. It also makes sure the feature list is again alphabetically sorted. Change-Id: Ib5276e06b64f01a8d6b92067d4a74274a9555636 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | | Fix crash on unsetting request interceptorAllan Sandfeld Jensen2019-02-261-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Don't access nullpointer. Also don't print developer warnings to end-users. Change-Id: I273101dd581a335464ff2dbae5095bc99e455649 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Make client certificate store thread safeAllan Sandfeld Jensen2019-02-256-34/+70
| | | | | | | | | | | | | | | | | | | | | | | | If the users manipulate the API from the UI, we need to read from the UI thread as well. Change-Id: I8af787a357954cff4fbdd94bcf27b880fb6aecb4 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Doc: Talk about 'empty string' in WebEngineProfile::downloadPathKai Koehne2019-02-241-2/+2
| | | | | | | | | | | | | | | | | | | | | This is clearer than 'null string', and actually also what the code checks for. Change-Id: I856de48016b609cb7a8be1286f8be51ad765abd6 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | | Update plugins.qmltypes for Qt 5.13Kai Koehne2019-02-242-2/+84
| | | | | | | | | | | | | | | | | | Task-number: QTBUG-73484 Change-Id: I9e8fb525e7dc77b46cff654b9c4b7a52b76cd45d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Add a setting to control if the PDF viewer is enabledMichael Brüning2019-02-228-5/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ChangeLog] Introduces a setting to control if the internal PDF viewer is enabled. By default, PDF documents will now be opened in the viewer instead of being downloaded. Change-Id: I78b3b3702ae3be3da58c9635720ba861db3de661 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Doc: Bump QtWebEngine import to 1.9Kai Koehne2019-02-211-2/+2
| | | | | | | | | | | | | | | Change-Id: I3728a4d0bb41412cd5059a63633ad383b2a378ea Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | | Revision WebEngineProfile::userNotificationKai Koehne2019-02-212-1/+2
| | | | | | | | | | | | | | | Change-Id: I6a5ff72c91cb1b173ca140efe3d4c95036f945eb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Do not pass ar to gn, update ChromiumMichal Klocek2019-02-212-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | qmake does not have cross specs archiver definition, so do not pass it. Updates Chromium: 29a45e8b7f Fix not working ar on windows c2a58ec0a9 Fix builds with no xrandr 76b0b85ab0 Disable download and print buttons in PDF viewer fa79a21c87 Fix extensions build for Windows on 71-based 6c56c89f1a Bypass CHECK for uninitialized resources when destroying plugin host Change-Id: I45eb7ab7fb3d9e8d9346559fdd7607bbac83675b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Add build time override of ninja jobsMichal Klocek2019-02-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Add sth like 'NINJAJOBS=-j20 make'. Helps to quickly investigate icecc issue without need to do qmake_all. Change-Id: I7438e9cd1a2b15bcbc1a4790bbc4d6596c5c7abd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Emit QWebEnginePage::selectionChanged asynchronouslyJüri Valdmann2019-02-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently selectionChanged is emitted from a Chromium task, meaning our MessagePump is blocked and, even with a nested QEventLoop, it's not possible to for Chromium code to make any progress during the handling of this signal. Fixes: QTBUG-73876 Change-Id: I45135238cffa81fb0db74ddfd53037c7f1b94348 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Try using authentication from QNetworkProxyMichal Klocek2019-02-195-5/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | Use credentials for QNetworkProxy if set. Done-With: Allan Sandfeld Jensen <allan.jensen@qt.io> Task-number: QTBUG-58121 Change-Id: I9c7328af90f3c60144c5ecf385529f663f0e46b2 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Remove not used define for sanitizerMichal Klocek2019-02-191-1/+0
| | | | | | | | | | | | | | | Change-Id: I3f5e55eb7a695c83b683d715640b10713e43aa95 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Minor. Remove unused m_index from pdfium_document_wrapper_qt.cppMichal Klocek2019-02-191-3/+0
| | | | | | | | | | | | | | | | | | | | | Fixes clang warning. Change-Id: Ib9851cabe7d578d5dd2abc2aa54891821aeeb38d Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Minor. Remove superfluous std::moveMichal Klocek2019-02-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Let the compiler decide to do copy elision/NRVO or move. Fixes clang warning. Change-Id: I257492c06593b25cb9325a674c6a8aeed8c67680 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Use qmake toolchain for gnMichal Klocek2019-02-182-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pass cc,cxx,ld,ar to gn, so it can be also build with clang for example. Updates Chormium: * bb8520a5 Fix build with sanitizer and icecc * be3cf3ab Add command line parameters for cc,cxx,ld,ar in gn * 7056415f Fixup build with older system ICU * 2b94bfe4 BASELINE: Update Chromium to 71.0.3578.140 Change-Id: I4c1653cc9f21c72571ebe3d60eca4a444cd106d9 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Remove hack with passing WebContentsAdapterClient as NativeViewAllan Sandfeld Jensen2019-02-184-18/+35
| | | | | | | | | | | | | | | | | | | | | | | | Instead delay creating our render view just a little bit further in WebContentImpl::OpenWindow until it calls delegate->WebContentsCreated() Change-Id: Idd911d208bbfe419a2567220933eccb2ba726347 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Fix undefined behavior with extensions disabledAllan Sandfeld Jensen2019-02-151-0/+2
| | | | | | | | | | | | | | | | | | | | | Return null as GuestManager. Change-Id: Idcc0a98cd80a38b27dba3d8c04b96af5e0904cad Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Merge remote-tracking branch 'origin/5.12' into 5.13Allan Sandfeld Jensen2019-02-1512-108/+166
|\| | | | | | | | | | | Change-Id: I0822fb8a10945a252cfd1aacaf0b6d9902cc8831
| * | Update ChromiumAllan Sandfeld Jensen2019-02-141-0/+0
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: 5c76f0592d0e [Backport] Fix for CVE-2019-5776 8b78be4530ae [Backport] Fix for CVE-2019-5775 and CVE-2019-5777 297b64d3d7d7 [Backport] Fix for CVE-2019-5779 42b4075a690d [Backport] Fix for CVE-2019-5783 5ee5529dea3a [Backport] Fix for CVE-2019-5781 5bebe28ae4d0 [Backport] Fix for security issue 912508 48192fb6548b [Backport] Update sqlite 3709910608cd [Backport] Fix for security issue 908358 Task-number: QTBUG-73417 Change-Id: If451e38f04bc4df90230acd51192a38c184df304 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * Update ChromiumAllan Sandfeld Jensen2019-02-121-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: 509f0033c434 [Backport] Fix for CVE-2019-5762 436537b89cc4 [Backport] Fix for CVE-2019-5763 69210928ceaa [Backport] Fix for CVE-2019-5764 c0f8161a7658 [Backport] Fix for security issue 922677 7f14eb3daf24 [Backport] Fix for security issue 899689 328129c5de09 [Backport] Fix for security issue 912520 a917b0698d8d [Backport] Fix for CVE-2019-5769 6c8f45a91435 [Backport] Fix for CVE-2019-5770 7b5e48775b3a [Backport] Fix for security issue 907047 Task-number: QTBUG-73417 Change-Id: I941f322313f42a6c92712f1d6cb7ae9a915bcf2e Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * Shutdown ProxyResolutionSerivceMichal Klocek2019-02-111-0/+3
| | | | | | | | | | | | | | | | Shut down the ProxyResolutionService before regenerating storage, it may have pending URLRequests. Change-Id: If79efc0bc942762dc48a50a12d74593ff1ee3989 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Better error reporting for QWebEngineUrlSchemeJüri Valdmann2019-02-113-6/+46
| | | | | | | | | | | | | | | | Add warnings for late registration and invalid configuration. Fixes: QTBUG-72842 Change-Id: I2c103c3b3581112cc885c3a1b4f42c011c3510ab Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| * Doc: Extend documentation of callbacksTamas Zakor2019-02-083-0/+29
| | | | | | | | | | | | | | | | Warn about callbacks on QWebEnginePage destruction. Task-number: QTBUG-72816 Change-Id: I8dbc297a8f364bc237b0672a63325af8da197e01 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Update ChromiumAllan Sandfeld Jensen2019-02-051-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: fe4f93f10929 Disable unsupported JavaScript APIs in PDF extension 99bfdd214657 Fix apps_shim build file to properly flag extension related files fd293fc03974 Minor. Drop dependency for ffmpeg for test_support 50d06b752453 [Backport] Fix for CVE-2019-5754 cf5bd0c9157c [Backport] Fix for CVE-2019-5755 7a5167caf765 [Backport] Fix for CVE-2019-5782 09ae6be5bb83 [Backport] Fix for CVE-2019-5756 6605d8f7b430 [Backport] Fix for CVE-2019-5757 3b390539f429 [Backport] Fix for CVE-2019-5758 c350fc2e3258 [Backport] Fix for CVE-2019-5759 63cf07a2a77c [Backport] Fix for CVE-2019-5760 Task-number: QTBUG-73417 Change-Id: Ia72fd847c8c36959189fe9648c81a3eb6dec6a10 Reviewed-by: Michal Klocek <michal.klocek@qt.io>