From 0e2b422fddef17cf9bfc8e31ed4a8f62566e27a0 Mon Sep 17 00:00:00 2001 From: Michal Klocek Date: Thu, 27 Oct 2022 16:35:51 +0200 Subject: Require minimum msvc version 14.29 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Instead of fixing the code to compile with lower version, simply require at least version present on ci. Fixes: QTBUG-108029 Change-Id: Ie6fbd7c3451a39c09dfb15e0cf9850672c9d4ea8 Reviewed-by: Michael BrĂ¼ning (cherry picked from commit 69f6761eb51029c5050d1fe0cf97a44a77fc7691) Reviewed-by: Qt Cherry-pick Bot --- configure.cmake | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/configure.cmake b/configure.cmake index 907ae615d..f485c1b4b 100644 --- a/configure.cmake +++ b/configure.cmake @@ -555,6 +555,13 @@ add_check_for_support( ) if(WIN32) + if(CMAKE_CXX_COMPILER_ID STREQUAL MSVC) + add_check_for_support( + MODULES QtWebEngine QtPdf + CONDITION NOT MSVC_VERSION LESS 1929 + MESSAGE "MSVC compiler version must be at least 14.29." + ) + endif() set(windowsSdkVersion $ENV{WindowsSDKVersion}) string(REGEX REPLACE "([0-9.]+).*" "\\1" windowsSdkVersion "${windowsSdkVersion}") string(REGEX REPLACE "^[0-9]+\\.[0-9]+\\.([0-9]+)\\.[0-9]+" "\\1" sdkMinor "${windowsSdkVersion}") -- cgit v1.2.3