From 1c8934c8ed1fa0eca96f980cd597c887678f4b14 Mon Sep 17 00:00:00 2001 From: Szabolcs David Date: Thu, 30 Sep 2021 16:48:04 +0200 Subject: Do not open screencast in DevTools by default If screencastEnabled preference is not found, ScreencastApp.ts defaults it to true. This happens at the first start of a browser application. Task-number: QTBUG-96942 Pick-to: 6.2 Change-Id: I15788737640cfe07c0016b31fc471906452aad1b Reviewed-by: Allan Sandfeld Jensen --- src/core/devtools_frontend_qt.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/core/devtools_frontend_qt.cpp b/src/core/devtools_frontend_qt.cpp index 81701b631..9a7736964 100644 --- a/src/core/devtools_frontend_qt.cpp +++ b/src/core/devtools_frontend_qt.cpp @@ -87,6 +87,8 @@ using namespace QtWebEngineCore; namespace { +constexpr char kScreencastEnabled[] = "screencastEnabled"; + std::unique_ptr BuildObjectForResponse(const net::HttpResponseHeaders *rh, bool success, int net_error) @@ -468,6 +470,10 @@ void DevToolsFrontendQt::HandleMessageFromDevToolsFrontend(const std::string &me m_loaders.insert(std::move(resource_loader)); return; } else if (method == "getPreferences") { + // Screencast is enabled by default if it's not present in the preference store. + if (!m_prefStore->GetValue(kScreencastEnabled, NULL)) + SetPreference(kScreencastEnabled, "false"); + m_preferences = std::move(*m_prefStore->GetValues()); SendMessageAck(request_id, &m_preferences); return; -- cgit v1.2.3