From 2af8c8c0b35bd37ba8df591d928720d2b894e816 Mon Sep 17 00:00:00 2001 From: Michal Klocek Date: Fri, 2 Feb 2024 18:21:05 +0100 Subject: Use only 'pdbpagesize' linker option for webenginecore debug MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using 'pdbpagesize' allows to create larger pdbfiles and it is needed for debug builds for qwebenginecore as it gets over 4Gb. However, these files are not yet well supported by older tooling therefore use the setting only for webengine debug build. This allows qtpdf debug builds and webenginecore/qtpdf release with debug info have functional pdb files with older tooling like cdb on windows. Pick-to: 6.7 6.6 Task-number: QTCREATORBUG-30308 Change-Id: Icd79a0d36b2f4b7f767d17ed79de3a4cbf96f1b4 Reviewed-by: Michael Brüning --- cmake/Functions.cmake | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cmake/Functions.cmake b/cmake/Functions.cmake index cbaf0c61e..e1044de8f 100644 --- a/cmake/Functions.cmake +++ b/cmake/Functions.cmake @@ -449,8 +449,10 @@ function(add_linker_options target buildDir completeStatic) target_link_options(${cmakeTarget} PRIVATE /DELAYLOAD:mf.dll /DELAYLOAD:mfplat.dll /DELAYLOAD:mfreadwrite.dll /DELAYLOAD:winmm.dll ) - # enable larger PDBs - target_link_options(${cmakeTarget} PRIVATE "/pdbpagesize:8192") + # enable larger PDBs if webenginecore debug build + if(cmakeTarget STREQUAL "WebEngineCore") + target_link_options(${cmakeTarget} PRIVATE "$<$:/pdbpagesize:8192>") + endif() endif() target_link_options(${cmakeTarget} PRIVATE "$<$:@${objects_rsp}>") if(NOT completeStatic) -- cgit v1.2.3