From 6546a8e122d8fe7725701d76285eb6156eebf8e4 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Sat, 23 Feb 2019 10:32:57 +0100 Subject: Fix crash on unsetting request interceptor Don't access nullpointer. Also don't print developer warnings to end-users. Change-Id: I273101dd581a335464ff2dbae5095bc99e455649 Reviewed-by: Michal Klocek --- src/webenginewidgets/api/qwebengineprofile.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/webenginewidgets/api/qwebengineprofile.cpp b/src/webenginewidgets/api/qwebengineprofile.cpp index 74dc14da0..32c000755 100644 --- a/src/webenginewidgets/api/qwebengineprofile.cpp +++ b/src/webenginewidgets/api/qwebengineprofile.cpp @@ -577,9 +577,11 @@ QWebEngineCookieStore* QWebEngineProfile::cookieStore() void QWebEngineProfile::setRequestInterceptor(QWebEngineUrlRequestInterceptor *interceptor) { Q_D(QWebEngineProfile); - interceptor->setProperty("deprecated", true); + if (interceptor) + interceptor->setProperty("deprecated", true); d->profileAdapter()->setRequestInterceptor(interceptor); - qWarning("Use of deprecated not tread-safe setter, use setUrlRequestInterceptor instead."); + if (interceptor) + qDebug("Use of deprecated not thread-safe setter, use setUrlRequestInterceptor instead."); } #endif /*! -- cgit v1.2.3