From 85523c788569f9276f102aadb1f6a7d0c043111c Mon Sep 17 00:00:00 2001 From: Pierre Rossi Date: Wed, 1 Oct 2014 12:43:50 +0200 Subject: TestBrowser: prevent popups from getting GCed This is a quick fix that only works because dialogs shouldn't outlive the page that opened them. We still have a problem for the new window case. Change-Id: I652e545f7eac394a915f7f173795dc0f187fc6ea Reviewed-by: Zeno Albisser --- tests/quicktestbrowser/quickwindow.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/quicktestbrowser/quickwindow.qml b/tests/quicktestbrowser/quickwindow.qml index ebde5b1ab..36668fc6d 100644 --- a/tests/quicktestbrowser/quickwindow.qml +++ b/tests/quicktestbrowser/quickwindow.qml @@ -346,7 +346,7 @@ ApplicationWindow { var tab = tabs.createEmptyTab() request.openIn(tab.item.webView) } else if (request.destination == WebEngineView.NewViewInDialog) { - var dialog = dialogComponent.createObject() + var dialog = dialogComponent.createObject(webEngineView) request.openIn(dialog.webView) } else { var component = Qt.createComponent("quickwindow.qml") -- cgit v1.2.3