From 9522dc8f71e189cf75eabdca4b3fab2d254d1542 Mon Sep 17 00:00:00 2001 From: Kirill Burtsev Date: Thu, 12 Mar 2020 16:08:51 +0000 Subject: Revert "Blacklist several Qt WebEngine quick dialog tests on macOS 10.13" This reverts commit d4022e03ccaeb92e41075f276e4011bd49627165 and partially fb430b4e104dd6313a776980b4798f1333193149. Reason for revert: initial blacklisting was done because of wrong assumption for test being flaky. But this is not the case. There is a non-zero chance that invalid build for macOS will be generated due to some undiscovered issue in build configuration or CI. Produced binaries are invalid and can't be used. If this first testcase fails then the whole suite will fail for every test. Blacklisting only moves failure further: first time from contextMenuRequested to javaScriptDialogRequested and etc, and second time to next test in whole suite tst_InspectorServer::testPageList. This creates a lot of really invalid failure entries in grafana testresults aggregator. It also creates confusion for the reason behind these kind of test failures and invalid bug report for other test failures. Task-number: QTBUG-76549 Change-Id: I1dfe850f6a9cabec352c6e2bd5471e7c4f2e99ca Reviewed-by: Allan Sandfeld Jensen --- tests/auto/quick/dialogs/BLACKLIST | 8 -------- 1 file changed, 8 deletions(-) delete mode 100644 tests/auto/quick/dialogs/BLACKLIST diff --git a/tests/auto/quick/dialogs/BLACKLIST b/tests/auto/quick/dialogs/BLACKLIST deleted file mode 100644 index 10b7391a0..000000000 --- a/tests/auto/quick/dialogs/BLACKLIST +++ /dev/null @@ -1,8 +0,0 @@ -[contextMenuRequested] -osx-10.13 -[javaScriptDialogRequested] -osx-10.13 -[colorDialogRequested] -osx-10.13 -[fileDialogRequested] -osx-10.13 -- cgit v1.2.3