From b18ed7089f22839621883e5a9e3903c22128b21a Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Tue, 13 Sep 2022 14:39:33 +0200 Subject: Avoid crashing with unparented accessibility We do not get the automation id in this case then, but we have run without it before. Fixes: QTBUG-106588 Change-Id: Ib65f1aaff1d7ef260df56c7de7198b0679e0d644 Reviewed-by: Michal Klocek (cherry picked from commit a79afbeaa0d5a0fe1152c221c063cf8e7304ed73) Reviewed-by: Qt Cherry-pick Bot --- src/core/browser_accessibility_qt.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/core/browser_accessibility_qt.cpp b/src/core/browser_accessibility_qt.cpp index 1d4fb06af..35d5b49d4 100644 --- a/src/core/browser_accessibility_qt.cpp +++ b/src/core/browser_accessibility_qt.cpp @@ -148,12 +148,12 @@ BrowserAccessibilityQt::~BrowserAccessibilityQt() BrowserAccessibilityInterface::BrowserAccessibilityInterface(BrowserAccessibilityQt *chromiumInterface) : q(chromiumInterface) { - Q_ASSERT(parent()); - Q_ASSERT(parent()->object()); - m_object = new QObject(parent()->object()); - QString name = toQt(q->GetAuthorUniqueId()); - if (!name.isEmpty()) - m_object->setObjectName(name); + if (parent() && parent()->object()) { + m_object = new QObject(parent()->object()); + QString name = toQt(q->GetAuthorUniqueId()); + if (!name.isEmpty()) + m_object->setObjectName(name); + } m_id = QAccessible::registerAccessibleInterface(this); } -- cgit v1.2.3