From d1168fda00c6eaff0f367d969639eec9adadb907 Mon Sep 17 00:00:00 2001 From: Michal Klocek Date: Fri, 8 Apr 2016 13:52:34 +0200 Subject: Fix crash while settingPersistentStoragePath Get rid of dangling pointer on storage removal in URLRequestContextGetterQt. This is accessed later in generateHttpCache. Task-number: QTBUG-52468 Change-Id: I03c0b3186b01046e17258af838bf5f9adc435da0 Reviewed-by: Joerg Bornemann --- src/core/url_request_context_getter_qt.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/core/url_request_context_getter_qt.cpp b/src/core/url_request_context_getter_qt.cpp index 20efec295..07833a9f8 100644 --- a/src/core/url_request_context_getter_qt.cpp +++ b/src/core/url_request_context_getter_qt.cpp @@ -153,8 +153,11 @@ void URLRequestContextGetterQt::generateStorage() Q_ASSERT(m_urlRequestContext); // We must stop all requests before deleting their backends. - if (m_storage) + if (m_storage) { cancelAllUrlRequests(); + // we need to get rid of dangling pointer due to coming storage deletion + m_urlRequestContext->set_http_transaction_factory(0); + } m_storage.reset(new net::URLRequestContextStorage(m_urlRequestContext.get())); -- cgit v1.2.3