From 82fe139dae5205a1683fb2b344c5dc867597c443 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Fri, 30 Apr 2021 17:15:57 +0200 Subject: Move createWindow to a signal Ports QQuickWebEngineNewViewRequest to QtWebEngineCore. [ChangeLog][QtWebEngineQuick][WebEngineView] WebEngineView::NewViewRequested is now handled with WebEngineView::acceptAsNewView() instead of with WebEngineNewViewRequest::openIn(). Task-number: QTBUG-74587 Change-Id: I9b27128948076e13f2c228458e1e7491df12153d Reviewed-by: Qt CI Bot Reviewed-by: Michal Klocek --- examples/webengine/quicknanobrowser/BrowserWindow.qml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'examples') diff --git a/examples/webengine/quicknanobrowser/BrowserWindow.qml b/examples/webengine/quicknanobrowser/BrowserWindow.qml index 1b8915df2..2fa4019c1 100644 --- a/examples/webengine/quicknanobrowser/BrowserWindow.qml +++ b/examples/webengine/quicknanobrowser/BrowserWindow.qml @@ -518,19 +518,19 @@ ApplicationWindow { onNewViewRequested: function(request) { if (!request.userInitiated) print("Warning: Blocked a popup window."); - else if (request.destination === WebEngineView.NewViewInTab) { + else if (request.destination === WebEngineNewViewRequest.InNewTab) { var tab = tabs.createEmptyTab(currentWebView.profile); tabs.currentIndex = tabs.count - 1; - request.openIn(tab.item); - } else if (request.destination === WebEngineView.NewViewInBackgroundTab) { + tab.item.acceptAsNewView(request); + } else if (request.destination === WebEngineNewViewRequest.InNewBackgroundTab) { var backgroundTab = tabs.createEmptyTab(currentWebView.profile); - request.openIn(backgroundTab.item); - } else if (request.destination === WebEngineView.NewViewInDialog) { + backgroundTab.item.acceptAsNewView(request); + } else if (request.destination === WebEngineNewViewRequest.InNewDialog) { var dialog = applicationRoot.createDialog(currentWebView.profile); - request.openIn(dialog.currentWebView); + dialog.currentWebView.acceptAsNewView(request); } else { var window = applicationRoot.createWindow(currentWebView.profile); - request.openIn(window.currentWebView); + window.currentWebView.acceptAsNewView(request); } } -- cgit v1.2.3