From abd050e9806123cbc6288e7d33ed01ceb2921766 Mon Sep 17 00:00:00 2001 From: Kirill Burtsev Date: Tue, 13 Jul 2021 12:21:50 +0200 Subject: Remove duplicated 'downloadProgress' in favor of separate signals Pick-to: 6.2 Change-Id: Ib825d63c89e591e740b206f43c3eadbf32319daa Reviewed-by: Allan Sandfeld Jensen --- src/core/api/qwebenginedownloadrequest.cpp | 14 -------------- src/core/api/qwebenginedownloadrequest.h | 2 -- 2 files changed, 16 deletions(-) (limited to 'src/core/api') diff --git a/src/core/api/qwebenginedownloadrequest.cpp b/src/core/api/qwebenginedownloadrequest.cpp index eaf335a41..222336239 100644 --- a/src/core/api/qwebenginedownloadrequest.cpp +++ b/src/core/api/qwebenginedownloadrequest.cpp @@ -205,7 +205,6 @@ void QWebEngineDownloadRequestPrivate::update(const ProfileAdapterClient::Downlo totalBytes = info.totalBytes; Q_EMIT q->totalBytesChanged(); } - Q_EMIT q->downloadProgress(receivedBytes, totalBytes); } if (info.done) @@ -351,19 +350,6 @@ quint32 QWebEngineDownloadRequest::id() const \sa state(), DownloadState */ -/*! - \fn void QWebEngineDownloadRequest::downloadProgress(qint64 bytesReceived, qint64 bytesTotal) - - This signal is emitted to indicate the progress of the download request. - - The \a bytesReceived parameter indicates the number of bytes received, while - \a bytesTotal indicates the total number of bytes expected to be downloaded. - If the size of the file to be downloaded is not known, \c bytesTotal will be - 0. - - \sa totalBytes(), receivedBytes() -*/ - /*! \enum QWebEngineDownloadRequest::DownloadState diff --git a/src/core/api/qwebenginedownloadrequest.h b/src/core/api/qwebenginedownloadrequest.h index 28d0fb5f2..35ed4263b 100644 --- a/src/core/api/qwebenginedownloadrequest.h +++ b/src/core/api/qwebenginedownloadrequest.h @@ -150,8 +150,6 @@ public Q_SLOTS: Q_SIGNALS: void stateChanged(QWebEngineDownloadRequest::DownloadState state); - //TODO: fix it for qml - void downloadProgress(qint64 bytesReceived, qint64 bytesTotal); void savePageFormatChanged(); void receivedBytesChanged(); void totalBytesChanged(); -- cgit v1.2.3