From 4c4ac0df9cea39b8d2a78c3563dda5fee199c9e8 Mon Sep 17 00:00:00 2001 From: Kirill Burtsev Date: Thu, 24 Mar 2022 13:46:51 +0100 Subject: Introduce http status code domain for loading info Fix inconsistency in reporting load info error category for http status codes, which across versions was reported either as internal error category or just no error domain. Add new separate domain for http status codes. [ChangeLog][QWebEngineLoadingInfo] Added HttpStatusCodeDomain for http status code range of errors Fixes: QTBUG-94963 Change-Id: I9fd496248c6fa33c424d758e9a0be99758aaf061 Reviewed-by: Qt CI Bot Reviewed-by: Benjamin Terrier Reviewed-by: Michal Klocek --- src/core/web_engine_error.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/core/web_engine_error.cpp') diff --git a/src/core/web_engine_error.cpp b/src/core/web_engine_error.cpp index a6580d76b..ff46be5c8 100644 --- a/src/core/web_engine_error.cpp +++ b/src/core/web_engine_error.cpp @@ -65,6 +65,10 @@ const int endErrors = -900; WebEngineError::ErrorDomain WebEngineError::toQtErrorDomain(int error_code) { + // net errors are always negative values, and https response codes are positive + if (error_code > 0) + return HttpStatusCodeDomain; + // Chromium's ranges from net/base/net_error_list.h: // 0 No error // 1- 99 System related errors -- cgit v1.2.3