From 30f99d80d809e373c3a39b49a4c4c8cb10f1f3cd Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Tue, 9 Jul 2019 11:08:10 +0200 Subject: Disable optimization of V8 for MSVC debug It leads to mismatching iterator debugging at runtime. We only avoid it on the CI because they run all the tests as release. Change-Id: I570fb252c050ad966d205688deba5e75d02c21bb Reviewed-by: Michal Klocek --- src/core/config/common.pri | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/core') diff --git a/src/core/config/common.pri b/src/core/config/common.pri index 18bd358f3..eabbf4ec0 100644 --- a/src/core/config/common.pri +++ b/src/core/config/common.pri @@ -95,6 +95,10 @@ CONFIG(debug, debug|release) { gn_args += use_debug_fission=false # MSVC requires iterator debug to always match and Qt has leaves it default on. msvc: gn_args += enable_iterator_debugging=true + + # We also can not have optimized V8 binaries for MSVC as iterator debugging + # would mismatch. + msvc|v8base_debug: gn_args += v8_optimized_debug=false } !webcore_debug: gn_args += remove_webcore_debug_symbols=true -- cgit v1.2.3