From 3ccbfd5cfb4864903bddac0fb9481d11c42a9f53 Mon Sep 17 00:00:00 2001
From: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
Date: Thu, 7 Jan 2016 13:16:13 +0100
Subject: Avoid creating contents adapter on webchannel access
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Postpones the setting of webchannels until the content adapter is
created normally. This also simplifies maintaining it over changing
adapters.

Change-Id: I19b861acd3310a7d98c79059911f6ce8c042760b
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
---
 src/webengine/api/qquickwebengineview.cpp   | 39 +++++++++++++----------------
 src/webengine/api/qquickwebengineview_p_p.h |  1 +
 2 files changed, 19 insertions(+), 21 deletions(-)

(limited to 'src/webengine')

diff --git a/src/webengine/api/qquickwebengineview.cpp b/src/webengine/api/qquickwebengineview.cpp
index e855d2ad1..663118574 100644
--- a/src/webengine/api/qquickwebengineview.cpp
+++ b/src/webengine/api/qquickwebengineview.cpp
@@ -111,6 +111,7 @@ QQuickWebEngineViewPrivate::QQuickWebEngineViewPrivate()
     , devicePixelRatio(QGuiApplication::primaryScreen()->devicePixelRatio())
     , m_dpiScale(1.0)
     , m_backgroundColor(Qt::white)
+    , m_webChannel(0)
 {
     // The gold standard for mobile web content is 160 dpi, and the devicePixelRatio expected
     // is the (possibly quantized) ratio of device dpi to 160 dpi.
@@ -691,11 +692,6 @@ void QQuickWebEngineViewPrivate::adoptWebContents(WebContentsAdapter *webContent
 
     Q_Q(QQuickWebEngineView);
 
-    // memorize what webChannel we had for the previous adapter
-    QQmlWebChannel *qmlWebChannel = NULL;
-    if (adapter)
-        qmlWebChannel = qobject_cast<QQmlWebChannel *>(adapter->webChannel());
-
     // This throws away the WebContentsAdapter that has been used until now.
     // All its states, particularly the loading URL, are replaced by the adopted WebContentsAdapter.
     WebContentsAdapterOwner *adapterOwner = new WebContentsAdapterOwner(adapter);
@@ -704,8 +700,9 @@ void QQuickWebEngineViewPrivate::adoptWebContents(WebContentsAdapter *webContent
     adapter->initialize(this);
 
     // associate the webChannel with the new adapter
-    if (qmlWebChannel)
-        adapter->setWebChannel(qmlWebChannel);
+    if (m_webChannel)
+        adapter->setWebChannel(m_webChannel);
+
     // set initial background color if non-default
     if (m_backgroundColor != Qt::white)
         adapter->backgroundColorChanged();
@@ -751,6 +748,8 @@ void QQuickWebEngineViewPrivate::ensureContentsAdapter()
         adapter->initialize(this);
         if (m_backgroundColor != Qt::white)
             adapter->backgroundColorChanged();
+        if (m_webChannel)
+            adapter->setWebChannel(m_webChannel);
         if (explicitUrl.isValid())
             adapter->load(explicitUrl);
         // push down the page's user scripts
@@ -898,11 +897,8 @@ void QQuickWebEngineViewPrivate::setProfile(QQuickWebEngineProfile *profile)
     if (adapter && adapter->browserContext() != browserContextAdapter()->browserContext()) {
         // When the profile changes we need to create a new WebContentAdapter and reload the active URL.
         QUrl activeUrl = adapter->activeUrl();
-        QQmlWebChannel *qmlWebChannel = qobject_cast<QQmlWebChannel *>(adapter->webChannel());
         adapter = 0;
         ensureContentsAdapter();
-        if (qmlWebChannel)
-            adapter->setWebChannel(qmlWebChannel);
 
         if (!explicitUrl.isValid() && activeUrl.isValid())
             adapter->load(activeUrl);
@@ -1119,23 +1115,24 @@ QQuickWebEngineHistory *QQuickWebEngineView::navigationHistory() const
 QQmlWebChannel *QQuickWebEngineView::webChannel()
 {
     Q_D(QQuickWebEngineView);
-    d->ensureContentsAdapter();
-    QQmlWebChannel *qmlWebChannel = qobject_cast<QQmlWebChannel *>(d->adapter->webChannel());
-    Q_ASSERT(!d->adapter->webChannel() || qmlWebChannel);
-    if (!qmlWebChannel) {
-        qmlWebChannel = new QQmlWebChannel(this);
-        d->adapter->setWebChannel(qmlWebChannel);
+    if (!d->m_webChannel) {
+        d->m_webChannel = new QQmlWebChannel(this);
+        if (d->adapter)
+            d->adapter->setWebChannel(d->m_webChannel);
     }
-    return qmlWebChannel;
+
+    return d->m_webChannel;
 }
 
 void QQuickWebEngineView::setWebChannel(QQmlWebChannel *webChannel)
 {
     Q_D(QQuickWebEngineView);
-    bool notify = (d->adapter->webChannel() == webChannel);
-    d->adapter->setWebChannel(webChannel);
-    if (notify)
-        Q_EMIT webChannelChanged();
+    if (d->m_webChannel == webChannel)
+        return;
+    d->m_webChannel = webChannel;
+    if (d->adapter)
+        d->adapter->setWebChannel(webChannel);
+    Q_EMIT webChannelChanged();
 }
 
 void QQuickWebEngineView::grantFeaturePermission(const QUrl &securityOrigin, QQuickWebEngineView::Feature feature, bool granted)
diff --git a/src/webengine/api/qquickwebengineview_p_p.h b/src/webengine/api/qquickwebengineview_p_p.h
index 8daf1f988..888828b2f 100644
--- a/src/webengine/api/qquickwebengineview_p_p.h
+++ b/src/webengine/api/qquickwebengineview_p_p.h
@@ -205,6 +205,7 @@ public:
     qreal devicePixelRatio;
     QMap<quint64, QJSValue> m_callbacks;
     QList<QSharedPointer<CertificateErrorController> > m_certificateErrorControllers;
+    QQmlWebChannel *m_webChannel;
 
 private:
     QScopedPointer<QtWebEngineCore::UIDelegatesManager> m_uIDelegatesManager;
-- 
cgit v1.2.3