From 824f35baf639ae6db8e2e732b0ab8d3fbbf73994 Mon Sep 17 00:00:00 2001 From: Michal Klocek Date: Thu, 6 Oct 2016 16:12:47 +0200 Subject: Fix Q_ASSERT when m_messageBubbleItem is not created When custom dialogs are created for FormValidationRequest, it is possible to accept Show request but reject Move request, in that case default MessageBubbleItem is not created and request should be ignored. Change-Id: I5f168802a66d88baa68d76396a073b5ff6517542 Reviewed-by: Peter Varga --- src/webengine/ui_delegates_manager.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/webengine') diff --git a/src/webengine/ui_delegates_manager.cpp b/src/webengine/ui_delegates_manager.cpp index 6896b850d..a37484023 100644 --- a/src/webengine/ui_delegates_manager.cpp +++ b/src/webengine/ui_delegates_manager.cpp @@ -523,7 +523,8 @@ void UIDelegatesManager::hideMessageBubble() void UIDelegatesManager::moveMessageBubble(const QRect &anchor) { - Q_ASSERT(!m_messageBubbleItem.isNull()); + if (m_messageBubbleItem.isNull()) + return; QQmlProperty(m_messageBubbleItem.data(), QStringLiteral("x")).write(anchor.x()); QQmlProperty(m_messageBubbleItem.data(), QStringLiteral("y")).write(anchor.y() + anchor.size().height()); -- cgit v1.2.3