From f1f763cf3c7254406b7b6f01551b6624210bb834 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Tue, 12 Jan 2021 15:22:30 +0100 Subject: Fix leak in QQuickWebEngineViewPrivate::contextMenuRequested Change-Id: Idb41daa68709c769330527a713689241ac073359 Reviewed-by: Kirill Burtsev --- src/webengine/api/qquickwebengineview.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/webengine') diff --git a/src/webengine/api/qquickwebengineview.cpp b/src/webengine/api/qquickwebengineview.cpp index 7b875bf55..a0395f1c1 100644 --- a/src/webengine/api/qquickwebengineview.cpp +++ b/src/webengine/api/qquickwebengineview.cpp @@ -235,7 +235,6 @@ void QQuickWebEngineViewPrivate::contextMenuRequested(const WebEngineContextMenu m_contextMenuData = data; - QQuickWebEngineContextMenuRequest *request = new QQuickWebEngineContextMenuRequest(data); QQmlEngine *engine = qmlEngine(q); // TODO: this is a workaround for QTBUG-65044 @@ -243,6 +242,7 @@ void QQuickWebEngineViewPrivate::contextMenuRequested(const WebEngineContextMenu return; // mark the object for gc by creating temporary jsvalue + QQuickWebEngineContextMenuRequest *request = new QQuickWebEngineContextMenuRequest(data); engine->newQObject(request); Q_EMIT q->contextMenuRequested(request); -- cgit v1.2.3