From 8f7ad43d9da54f7baba3de5093f11235158f8066 Mon Sep 17 00:00:00 2001
From: Peter Varga <pvarga@inf.u-szeged.hu>
Date: Mon, 12 Jul 2021 16:15:08 +0200
Subject: Various clean-ups around QWebEngineView

Change-Id: I16f27054871f63526946101e07cb0dcf4aa3b390
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit e4bb4b8bc443fa78c0cd4509cc8ec1251e8296ae)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 src/webenginewidgets/api/qwebengineview.cpp        | 54 ++++++++++++----------
 src/webenginewidgets/api/qwebengineview.h          | 11 ++---
 src/webenginewidgets/api/qwebengineview_p.h        | 12 ++---
 .../render_widget_host_view_qt_delegate_widget.cpp |  2 -
 4 files changed, 40 insertions(+), 39 deletions(-)

(limited to 'src/webenginewidgets')

diff --git a/src/webenginewidgets/api/qwebengineview.cpp b/src/webenginewidgets/api/qwebengineview.cpp
index d72673225..89cc356fe 100644
--- a/src/webenginewidgets/api/qwebengineview.cpp
+++ b/src/webenginewidgets/api/qwebengineview.cpp
@@ -1,6 +1,6 @@
 /****************************************************************************
 **
-** Copyright (C) 2016 The Qt Company Ltd.
+** Copyright (C) 2021 The Qt Company Ltd.
 ** Contact: https://www.qt.io/licensing/
 **
 ** This file is part of the QtWebEngine module of the Qt Toolkit.
@@ -37,48 +37,52 @@
 **
 ****************************************************************************/
 
+#include "qwebenginenotificationpresenter_p.h"
 #include "qwebengineview.h"
 #include "qwebengineview_p.h"
+#include "render_widget_host_view_qt_delegate_widget.h"
 
 #include <QtWebEngineCore/private/qwebenginepage_p.h>
+#include <QtWebEngineCore/qwebenginecontextmenurequest.h>
+#include <QtWebEngineCore/qwebenginehistory.h>
+#include <QtWebEngineCore/qwebenginehttprequest.h>
 #include <QtWebEngineCore/qwebengineprofile.h>
-#include "render_widget_host_view_qt_delegate_widget.h"
-#include "web_contents_adapter.h"
-#include "file_picker_controller.h"
-#include "qwebenginenotificationpresenter_p.h"
 #include "color_chooser_controller.h"
-#include <QStandardPaths>
-#if QT_CONFIG(action)
-#include <QAction>
-#endif
-#if QT_CONFIG(menu)
-#include <QMenu>
-#endif
+#include "web_contents_adapter.h"
+
 #include <QContextMenuEvent>
 #include <QToolTip>
 #include <QVBoxLayout>
+#include <QKeyEvent>
+#include <QIcon>
+#include <QStyle>
+#include <QGuiApplication>
+
+#if QT_CONFIG(action)
+#include <QAction>
+#endif
+
 #if QT_CONFIG(colordialog)
-#    include <QColorDialog>
+#include <QColorDialog>
 #endif
-#include <QContextMenuEvent>
+
 #if QT_CONFIG(filedialog)
-#    include <QFileDialog>
+#include <QFileDialog>
+#include <QStandardPaths>
+#include "file_picker_controller.h"
 #endif
-#include <QKeyEvent>
-#include <QIcon>
+
 #if QT_CONFIG(inputdialog)
-#    include <QInputDialog>
+#include <QInputDialog>
 #endif
-#include <QLayout>
-#include <QLoggingCategory>
+
 #if QT_CONFIG(menu)
-#    include <QMenu>
+#include <QMenu>
 #endif
+
 #if QT_CONFIG(messagebox)
-#    include <QMessageBox>
+#include <QMessageBox>
 #endif
-#include <QStyle>
-#include <QGuiApplication>
 
 #if QT_CONFIG(webengine_printing_and_pdf)
 #include "printing/printer_worker.h"
@@ -194,7 +198,7 @@ void QWebEngineViewPrivate::contextMenuRequested(QWebEngineContextMenuRequest *r
 
     Q_UNREACHABLE();
 #else
-    Q_UNUSED(data);
+    Q_UNUSED(request);
 #endif // QT_CONFIG(action)
 }
 
diff --git a/src/webenginewidgets/api/qwebengineview.h b/src/webenginewidgets/api/qwebengineview.h
index 417dff43e..fbb230dda 100644
--- a/src/webenginewidgets/api/qwebengineview.h
+++ b/src/webenginewidgets/api/qwebengineview.h
@@ -1,6 +1,6 @@
 /****************************************************************************
 **
-** Copyright (C) 2016 The Qt Company Ltd.
+** Copyright (C) 2021 The Qt Company Ltd.
 ** Contact: https://www.qt.io/licensing/
 **
 ** This file is part of the QtWebEngine module of the Qt Toolkit.
@@ -40,22 +40,21 @@
 #ifndef QWEBENGINEVIEW_H
 #define QWEBENGINEVIEW_H
 
-#include <QtGui/qpainter.h>
 #include <QtGui/QPageLayout>
 #include <QtGui/qpageranges.h>
-#include <QtNetwork/qnetworkaccessmanager.h>
 #include <QtWidgets/qwidget.h>
 
 #include <QtWebEngineWidgets/qtwebenginewidgetsglobal.h>
-#include <QtWebEngineCore/qwebenginecontextmenurequest.h>
-#include <QtWebEngineCore/qwebenginehttprequest.h>
 #include <QtWebEngineCore/qwebenginepage.h>
 
 QT_BEGIN_NAMESPACE
+
 class QContextMenuEvent;
 class QPrinter;
 class QUrl;
-class QWebEnginePage;
+class QWebEngineContextMenuRequest;
+class QWebEngineHistory;
+class QWebEngineHttpRequest;
 class QWebEngineSettings;
 class QWebEngineViewAccessible;
 class QWebEngineViewPrivate;
diff --git a/src/webenginewidgets/api/qwebengineview_p.h b/src/webenginewidgets/api/qwebengineview_p.h
index af395fb39..db22c95b5 100644
--- a/src/webenginewidgets/api/qwebengineview_p.h
+++ b/src/webenginewidgets/api/qwebengineview_p.h
@@ -1,6 +1,6 @@
 /****************************************************************************
 **
-** Copyright (C) 2016 The Qt Company Ltd.
+** Copyright (C) 2021 The Qt Company Ltd.
 ** Contact: https://www.qt.io/licensing/
 **
 ** This file is part of the QtWebEngine module of the Qt Toolkit.
@@ -51,21 +51,21 @@
 // We mean it.
 //
 
-#include <QtWebEngineWidgets/qwebengineview.h>
-#include <QtWebEngineCore/private/qwebenginepage_p.h>
-#include <QtWebEngineCore/qwebenginecontextmenurequest.h>
+#include <QtWebEngineCore/private/qwebenginepage_p.h> // PageView
 #include <QtWidgets/qaccessiblewidget.h>
 
 #include "render_view_context_menu_qt.h"
 
 namespace QtWebEngineCore {
-class QPrinter;
+class QWebEngineContextMenuRequest;
 class RenderWidgetHostViewQtDelegateWidget;
 class RenderWidgetHostViewQtDelegate;
 }
 
 QT_BEGIN_NAMESPACE
 
+class QMenu;
+class QPrinter;
 class QWebEngineView;
 
 class QWebEngineViewPrivate : public PageView
@@ -141,7 +141,7 @@ private:
 class QContextMenuBuilder : public QtWebEngineCore::RenderViewContextMenuQt
 {
 public:
-    QContextMenuBuilder(QWebEngineContextMenuRequest *reqeust, QWebEngineView *view, QMenu *menu);
+    QContextMenuBuilder(QWebEngineContextMenuRequest *request, QWebEngineView *view, QMenu *menu);
 
 private:
     virtual bool hasInspector() override;
diff --git a/src/webenginewidgets/render_widget_host_view_qt_delegate_widget.cpp b/src/webenginewidgets/render_widget_host_view_qt_delegate_widget.cpp
index 0869b254e..9bfa49065 100644
--- a/src/webenginewidgets/render_widget_host_view_qt_delegate_widget.cpp
+++ b/src/webenginewidgets/render_widget_host_view_qt_delegate_widget.cpp
@@ -46,9 +46,7 @@
 #include "qwebengineview_p.h"
 
 #include <QGuiApplication>
-#include <QLayout>
 #include <QMouseEvent>
-#include <QOpenGLContext>
 #include <QResizeEvent>
 #include <QSGImageNode>
 #include <QWindow>
-- 
cgit v1.2.3